Local Authentication Feature as an extension to HLD #1315 SONiC PAC support HLD #1469
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
IMHO Since this is an extension, the new files must be added to the same parent directory |
Yarden-Z
reviewed
Oct 10, 2023
| } | ||
| } | ||
|
|
||
| typedef auth_priority_enumeration { |
There was a problem hiding this comment.
Why do we need both order and priority?
|
community review meeting record https://zoom.us/rec/share/-58qaQcK0bdjEbqFyfb9-7LONrUXzc8jkp6fOgUUi2izAwt00ySu3m8HZxKqbrjN.KQFnh_RE0uhl7qxe |
|
@kishorgovind can you please help to add the code PRs to this HLD by referring to #806? Thanks |
|
code PR is not ready, move to backlog for future release |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is HLD extension that describes Local Authentication feature for Port Access Control. This HLD acts as an extension to HLD #1315