Dropped Packet Notification (MOD) support #1786
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
madhupalu
commented
Aug 26, 2024
doc/sflow/sflow_hld.md
Outdated
| @@ -645,12 +708,15 @@ An sFlowOrch is introduced in the Orchagent to handle configuration requests. Th | |||
|
|
|||
| Also, it monitors the SFLOW_SESSIONS_TABLE and PORT state to determine sampling rate / speed changes to derive and set the sampling rate for all the interfaces. Ingress/Egress Sampling is enabled on the interfaces based on direction setting. It uses the SAI samplepacket APIs to set each ports's sampling rate. | |||
|
|
|||
| Finally, sFlowOrch facilitates the creation/deletion of dropped packet sessions as well as get/set of session specific attributes. sFlowOrch sets the genetlink host interface that is to be used by the SAI driver to deliver dropped packet notifications and reason codes. | |||
There was a problem hiding this comment.
@rck-innovium is the existing API's enough or need to extend it orchagent to extend new Mirror-in-drop / SAI API spec 2.0?
There was a problem hiding this comment.
Orchagent needs to be extended to invoke the SAI TAM APIs described in [https://github.com/opencomputeproject/SAI/blob/master/doc/TAM/SAI-Proposal-TAM-MOD-Localhost.md#50--api-example SAI Proposal TAM MOD Localhost - API Example]
madhupalu
commented
Aug 30, 2024
| table_attr[1].value=discard_packet_trap_id; // Object referencing DISCARD packet traps | ||
|
|
||
| table_attr[2].id=SAI_HOSTIF_TABLE_ENTRY_ATTR_CHANNEL; | ||
| table_attr[2].value=SAI_HOSTIF_TABLE_ENTRY_CHANNEL_TYPE_GENETLINK; |
There was a problem hiding this comment.
@rck-innovium shouldn't be used "events" as MCGRP NAME for drop notifications?
sai_host_if_attr[2].id= SAI_HOSTIF_ATTR_GENETLINK_MCGRP_NAME;
sai_host_if_attr[2].value="events";
There was a problem hiding this comment.
Yes, you are right.
attr_list[attr_count].id = SAI_HOSTIF_ATTR_GENETLINK_MCGRP_NAME;
strncpy(attr_list[attr_count].value.chardata, "events", 31);
attr_list[attr_count].value.chardata[31] = '\0';
attr_count++;
rck-innovium
force-pushed
the
rck_sflow_mod
branch
from
a3ee293
to
c74486f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.