[docker-mgmt-framework]: update mgmt framework docker to support sonic-cli cmd #6148
Conversation
This reverts commit 3fa0a72.
|
retest vsimage please |
|
@lguohan @renukamanavalan @xinanqiu help needed to get this PR merged to be part of 202012 release. |
Removed the lines accidentally added from other branch.
Revert the change to keep the links for CLI authentication. We need to bring in CA certificate changes to replace these files.
|
retest broadcom please |
|
retest mellanox please |
|
retest vsimage please |
|
retest baseimage please |
|
@renukamanavalan @lguohan - AAA improvements (hamd) is work in progress and will not be able to make it in to 202012 release. Until then we have to mount /etc/passwd and /etc/groups. The AAA improvements will remove the need to mount. Kwan has addressed all the reviews and resolved merge conflicts as well. Requesting review so that we can get this PR merged in 202012 release. Keeping this PR open to long will result again in merge conflicts and too much back & forth. |
|
i think the title can be updated to reflect the pr content. [docker-mgmt-framework]: update mgmt framework docker to support sonic-cli cmd |
kwangsuk
changed the title
kwangsuk
changed the title
|
Yes, Guohan. It is updated accordingly.
Thx/Kwan
From: lguohan <notifications@github.com>
Sent: Tuesday, January 12, 2021 8:10 AM
To: Azure/sonic-buildimage
Cc: Kim, Kwan; Author
Subject: Re: [Azure/sonic-buildimage] Update sonic cli (#6148)
[EXTERNAL EMAIL]
i think the title can be updated to reflect the pr content.
[docker-mgmt-framework]: update mgmt framework docker to support sonic-cli cmd
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub<#6148 (comment)>, or unsubscribe<https://github.com/notifications/unsubscribe-auth/ABRKTZ7TSCSH6IHAEJILZOLSZRX6BANCNFSM4URDKUFA>.
|
|
retest mellanox please |
|
retest vsimage please |
The python3-dev was removed as commented. |
|
@lguohan need help with the review of this PR. |
@lguohan, @renukamanavalan - yes please! |
|
@lguohan , @renukamanavalan - please provide your inputs so we can move forwards. |
|
Note that we believe that this PR is needed for [https://github.com//issues/6549] - please merge. |
…c-cli cmd (sonic-net#6148) - Why I did it migrate to python3 support add dependent packages for Klish allow login as non-root user - How I did it update sonic-cli script to start Klish with user name, system name and timeout update the Dockerfile.j2 to resolve dependent packages add python3-dev for Klish use - How to verify it Incremental buster build with sonic-net/sonic-mgmt-framework#76 and verify the sonic-cli - Description for the changelog Migrate to python3.7 support, update sonic-cli script and resolve package dependencies
- Why I did it
- How I did it
update sonic-cli script to start Klish with user name, system name and timeout
update the Dockerfile.j2 to resolve dependent packages
add python3-dev for Klish use
- How to verify it
Incremental buster build with sonic-net/sonic-mgmt-framework#76 and verify the sonic-cli
- Which release branch to backport (provide reason below if selected)
- Description for the changelog
Migrate to python3.7 support, update sonic-cli script and resolve package dependencies
- A picture of a cute animal (not mandatory but encouraged)