reddit: fix matching twice for reddit.com without www. #2208
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Addresses a regression introduced by #2202, which added `reddit.com` to the `short_post_url` pattern and made it possible for a post or comment URL to match BOTH that and `post_or_comment_url`. Since URLs match individually, and not as part of the line, all we need to make sure a shortlink really is one is to ensure that the link ends after the submission ID and optional trailing slash.
Exirel
approved these changes
Nov 7, 2021
The system works. |
4 tasks
|
OK, this py3.9 CI failure that magically appeared in #2209 definitely isn't related to that patch. @Exirel help, what could have possibly changed in the last two days to break ONLY this version of Python? Edit: This bug tracker entry linked from the Python 3.9.8 changelog seems related. It touches Edit the 2nd: Confirmed that the last successful py3.9 job was on 3.9.7, and the failing jobs for these two PRs are using 3.9.8. That's our scope for examining changes. |
|
CI failure discussion has its own issue now: #2210 |
4 tasks
dgw
added a commit
that referenced
this pull request
Nov 29, 2021
reddit: fix matching twice for reddit.com without www.
This comment has been minimized.
This comment has been minimized.
dgw
added a commit
that referenced
this pull request
Dec 11, 2021
reddit: fix matching twice for reddit.com without www. Modified new test file from master to contain the required header lines (future imports & coding comment) for 7.1.x branch.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Addresses a regression introduced by #2202 (itself a regression fix, ironically), which added
reddit.comto theshort_post_urlpattern and made it possible for a post or comment URL to match BOTH that andpost_or_comment_url.Since URLs match individually, and not as part of the line, all we need to make sure a shortlink really is one is to ensure that the link ends after the submission ID and optional trailing slash.
Checklist
make qa(runsmake qualityandmake test)reddit.py's URL matching invites madness.Notes
To the PR template's question: This does not resolve any GitHub issues, because @xnaas doesn't "submit GitHub issues while naked in bed" and reported the bug on IRC instead.