Merge pull request #864 from soutaro/hover-node-type

Let hover show the type of method call node
soutaro · Jul 11, 2023 · 38ea2a1 · 38ea2a1
2 parents c8f5213 + 0bd7d45
commit 38ea2a1
Show file tree

Hide file tree

Showing 2 changed files with 38 additions and 0 deletions.
diff --git a/lib/steep/server/lsp_formatter.rb b/lib/steep/server/lsp_formatter.rb
@@ -28,7 +28,16 @@ def format_hover_content(content)
 
           case call
           when TypeInference::MethodCall::Typed
+            io.puts <<~MD
+              ```rbs
+              #{call.actual_method_type.type.return_type}
+              ```
+
+              ----
+            MD
+
             method_types = call.method_decls.map(&:method_type)
+
             if call.is_a?(TypeInference::MethodCall::Special)
               method_types = [
                 call.actual_method_type.with(
@@ -250,6 +259,10 @@ def format_completion_docs(item)
           end
 
           io.string
+        when Services::CompletionProvider::KeywordArgumentItem
+          <<~MD
+            **Keyword argument**: `#{item.identifier}`
+          MD
         end
       end
 

diff --git a/test/server/lsp_formatter_test.rb b/test/server/lsp_formatter_test.rb
@@ -55,6 +55,11 @@ def foo: [A] (A) -> Array[A]
 
       comment = Server::LSPFormatter.format_hover_content(content)
       assert_equal <<~MD, comment
+        ```rbs
+        ::Array[::Integer]
+        ```
+
+        ----
         **Method type**:
         ```rbs
         [A] (A) -> ::Array[A]
@@ -90,6 +95,11 @@ def __foo__: () -> void
 
       comment = Server::LSPFormatter.format_hover_content(content)
       assert_equal <<~MD, comment
+        ```rbs
+        void
+        ```
+
+        ----
         **Method type**:
         ```rbs
         () -> void
@@ -125,6 +135,11 @@ def foo: [A] (A) -> Array[A]
 
       comment = Server::LSPFormatter.format_hover_content(content)
       assert_equal <<~MD, comment
+        ```rbs
+        ::Array[::Integer]
+        ```
+
+        ----
         **Method type**:
         ```rbs
         [A] (A) -> ::Array[A]
@@ -166,6 +181,11 @@ def foo: () -> Symbol
 
       comment = Server::LSPFormatter.format_hover_content(content)
       assert_equal <<~MD, comment
+        ```rbs
+        (::Integer | ::String | ::Symbol)
+        ```
+
+        ----
         **Method type**:
         ```rbs
           () -> ::Integer
@@ -206,6 +226,11 @@ def test_ruby_hover_method_call__special
 
         comment = Server::LSPFormatter.format_hover_content(content)
         assert_equal <<~MD.chomp, comment
+          ```rbs
+          ::Array[::Integer]
+          ```
+
+          ----
           **💡 Custom typing rule applies**
 
           ----