Merge pull request #552 from soutaro/rest-keyword-params

Fix method parameter type checking
soutaro · May 12, 2022 · ec2061a · ec2061a
2 parents 9b5bc0c + 3de467e
commit ec2061a
Show file tree

Hide file tree

Showing 2 changed files with 27 additions and 0 deletions.
diff --git a/lib/steep/type_inference/method_params.rb b/lib/steep/type_inference/method_params.rb
@@ -315,6 +315,7 @@ def self.build(node:, method_type:)
             when Interface::Function::Params::PositionalParams::Rest
               rest_types << param.type
               positional_params = nil
+              args.shift
               break
             when nil
               has_error = true

diff --git a/test/type_construction_test.rb b/test/type_construction_test.rb
@@ -8796,4 +8796,30 @@ class Foo < Class.new
       end
     end
   end
+
+  def test_keyword_param_methods
+    with_checker(<<-RBS) do |checker|
+module KeywordParamMethod
+  class Foo
+    def bar: (*String, name: Symbol) -> void
+  end 
+end
+    RBS
+
+      source = parse_ruby(<<-'RUBY')
+module KeywordParamMethod
+  class Foo
+    def bar(*args, name:)
+    end
+  end
+end
+      RUBY
+
+      with_standard_construction(checker, source) do |construction, typing|
+        construction.synthesize(source.node)
+
+        assert_no_error(typing)
+      end
+    end
+  end
 end