Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Better default config sets in Diagnostic::Ruby #787

Closed
soutaro opened this issue May 23, 2023 · 3 comments
Closed

Better default config sets in Diagnostic::Ruby #787

soutaro opened this issue May 23, 2023 · 3 comments
Labels
area/frontend Issues related to the tool frontend enhancement
Milestone
Steep 1.5

Comments

@soutaro
Copy link
Owner

soutaro commented May 23, 2023 •
edited
Loading

  • Some users want to use Steep just for completions/navigations. Adding a report nothing configuration would help them.
  • Many UnknownInstanceVariable are reported and makes the project have second thought about using Steep
  • Reporting UnsupportedSyntax doesn't make much sense
@soutaro soutaro changed the title Add *no report* template to `Diagnostic::Ruby Add *no report* template to Diagnostic::Ruby May 23, 2023
@soutaro soutaro added the area/frontend Issues related to the tool frontend label May 23, 2023
@soutaro soutaro added this to the Steep 1.5 milestone May 23, 2023
@soutaro soutaro changed the title Add *no report* template to Diagnostic::Ruby Better default config sets in Diagnostic::Ruby May 23, 2023
tk0miya added a commit to tk0miya/steep that referenced this issue May 23, 2023
@tk0miya
Suppress UnsupportedSyntax warnings by default
5cb0eb6 
UnsupportedSyntax warnings are meaningless message for users.  So they
should be suppressed by default.

refs: soutaro#787
@tk0miya tk0miya mentioned this issue May 23, 2023
Merged
tk0miya added a commit to tk0miya/steep that referenced this issue May 23, 2023
@tk0miya
Add Steep::Diagnostic::Ruby.silent template to suppress all warnings
7ffdf1f 
To use steep for completions and navigations, this adds a new settings
template `Steep::Diagnostic::Ruby.silent` that suppresses all warnings.

refs: soutaro#787
@tk0miya tk0miya mentioned this issue May 23, 2023
Merged
@soutaro
Copy link
Owner Author

soutaro commented May 24, 2023

We have strict template, but looks like it ignores to many diagnostics... Will update the config too.

@tk0miya
Copy link
Contributor

tk0miya commented May 24, 2023

In my eyes, the strict and lenient templates are very similar, and it's hard to understand their difference. Additionally, the default settings are much stricter than the strict template. So I feel the "strict" template is not strict. +1 for updating it (or both of them).

@soutaro
Copy link
Owner Author

soutaro commented Jul 12, 2023

Updated in #871.

@soutaro soutaro closed this as completed Jul 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
area/frontend Issues related to the tool frontend enhancement
Projects
Steep and RBS
Archived in project
Milestone
Steep 1.5
Development

No branches or pull requests
2 participants
@soutaro @tk0miya