Enable RBS collection feature #420
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pocke
force-pushed
the
rbs_collection
branch
from
768cbdf
to
9664bd4
Compare
pocke
force-pushed
the
rbs_collection
branch
from
9664bd4
to
f9f61ca
Compare
pocke
commented
Sep 9, 2021
| @@ -131,4 +131,80 @@ def test_diagnostics | |||
| end | |||
| end | |||
| end | |||
|
|
|||
| def test_collection_implicit | |||
There was a problem hiding this comment.
The added test cases check that the collection_lock is set (or not), but it doesn't test the libs' RBSs are loaded to the environment. I'm not sure where should I write a test to check it. Could you help me?
By the way, I've tested that Steep loads the libs, by hand.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR introduces
rbs collectionfeature, ruby/rbs#589, to Steep.Usage
rbs_collection.yamlexists in the same directory asSteepfile, Steep loads libraries' RBSs from the config file.collection_config pathis specified in Steepfile, Steep loads libraries' RBSs from the specified file.collection_config '../other/path/rbs_collection.yaml'in many cases.disable_collectionis specified in Steepfile, Steep ignoresrbs_collection.yaml.rbs_collection.yamldoesn't exist and no options are specified, Steep does nothing about rbs collection feature.