New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix unexpected error when or-asgn/and-asgn #517

Merged

soutaro merged 1 commit into soutaro:master from ksss:or-and-asgn

Mar 20, 2022

Contributor

ksss commented Mar 20, 2022

Fix #515

or-asgn/and-asgn may differ in the number of children under the send node.

$ ruby-parse --legacy -e 'a=[]; a[0] ||= 3'
(begin
  (lvasgn :a
    (array))
  (or-asgn
    (send
      (lvar :a) :[]
      (int 0)) # <= `(int 0)` is asgn.children[2]
    (int 3)))

$ ruby-parse --legacy -e 'self.a ||= 3'
(or-asgn
  (send
    (self) :a) # <= not have asgn.children[2]
  (int 3))

This PR support both pattern.


          Fix unexpected error when or-asgn/and-asgn

0027bb1

soutaro approved these changes

View reviewed changes

Owner

soutaro left a comment

Nice catch! 👍 👏

soutaro merged commit 079b718 into soutaro:master

ksss deleted the or-and-asgn branch

March 20, 2022 12:59

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet