Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refresh completion list if RBS file has a syntax error #766

Merged
merged 1 commit into from
Apr 25, 2023

Conversation

soutaro
Copy link
Owner

@soutaro soutaro commented Apr 25, 2023

This helps generating better result in the following scenario.

class Foo
  attr_reader name: 👈 Start completion here
end

The RBS file has a syntax error and it starts completion with nil nesting context, while the user expects ::Foo.

Setting is_incomplete: true in this case forces generating a new list after user typing some character, that would make the syntax correct.

@soutaro soutaro added this to the Steep 1.4 milestone Apr 25, 2023
@soutaro soutaro merged commit e3b060e into master Apr 25, 2023
@soutaro soutaro deleted the completion-incomplete branch April 25, 2023 05:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant