Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Change severity of block diagnostics #950

Merged
merged 1 commit into from
Oct 31, 2023
Merged

Change severity of block diagnostics #950

merged 1 commit into from
Oct 31, 2023

Conversation

soutaro
Copy link
Owner

@soutaro soutaro commented Oct 31, 2023

Because of #941, new BlockBodyTypeMismatch may be reported. Having lower severity than UnresolveOverloading make the users feel the diagnostics are disappeared.

This is not what we want, and gibing higher severity will preserve the type errors.

@soutaro soutaro added this to the Steep 1.6 milestone Oct 31, 2023
@soutaro soutaro merged commit 2c035f0 into master Oct 31, 2023
17 checks passed
@soutaro soutaro deleted the diagnostics branch October 31, 2023 02:39
@soutaro soutaro added area/frontend Issues related to the tool frontend Released The PR is already included in a published release labels Oct 31, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
area/frontend Issues related to the tool frontend Released The PR is already included in a published release
Projects
None yet
Milestone
Steep 1.6
Development

Successfully merging this pull request may close these issues.
1 participant
@soutaro