Handle absolute path #975
Merged
Handle absolute path #975
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The pattern being relative, it had no chance to match the absolute path provided as argument. Fixed by making absolute path relative to base_dir before checking against pattern.
lloeki
force-pushed
the
fix-absolute-path
branch
from
3f19d82
to
dfeed91
Compare
lloeki
added a commit
to lloeki/ale
that referenced
this pull request
Dec 6, 2023
lloeki
added a commit
to lloeki/ale
that referenced
this pull request
Dec 6, 2023
lloeki
added a commit
to lloeki/ale
that referenced
this pull request
Dec 6, 2023
soutaro
added
Released
lloeki
added a commit
to lloeki/ale
that referenced
this pull request
May 27, 2024
hsanson
pushed a commit
to dense-analysis/ale
that referenced
this pull request
Jun 25, 2024
* Add Ruby linter with Steep Fixes #3254 * Run steep instead of using language server LSP presents a few issues and this works around those. * Work around Steep path issue See soutaro/steep#975 * Add simple tests for steep * Add steep to supported tools * Pass linter * Add a comment regarding Steep's column counting * Make lnum an integer * Add Steep handler test * Fix separator for Windows * Escape Windows path separators for substitute() * Use ALEInfo (I) group * Use fnameescape instead of quotes * Skip linting for files not under steep root * Add and pass tests covering proper steep root lookup * Fix separator discrepancy * Use strict operators (match case) * Fix ordering * Use `is#` instead of `==#`
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
During development of this I found out that this would work:
but this would fail:
The pattern being relative, it had no chance to match the absolute path provided as argument.
Fixed by making absolute path relative to base_dir before checking against pattern.