Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Parent dirs in elfeed-score-rule-stats-file are not created automatically #32

Closed
yantar92 opened this issue Jul 24, 2023 · 3 comments
Closed

Comments

@yantar92
Copy link

When I try to set elfeed-score-rule-stats-file to a full path in a non-existing directory, elfeed-score errs, instead of creating that directory.

@sp1ff
Copy link
Owner

sp1ff commented Jul 25, 2023

Got a stack trace? Error message?

sp1ff added a commit that referenced this issue Jul 25, 2023
Setting `elfeed-score-rule-stats-file` to a path with intermediate
directories that don't exist will error-out. This fix will at
least attempt to create them.
@yantar92
Copy link
Author

yantar92 commented Jul 25, 2023 via email

sp1ff added a commit that referenced this issue Jul 27, 2023
Setting `elfeed-score-rule-stats-file` to a path with intermediate
directories that don't exist will error-out. This fix will at
least attempt to create them.

Also, update the CI workflow & prep for the merge.
sp1ff added a commit that referenced this issue Jul 28, 2023
Setting `elfeed-score-rule-stats-file` to a path with intermediate
directories that don't exist will error-out. This fix will at
least attempt to create them.

Also, update the CI workflow & generally prep for the merge
(new version &c)

As an aside, the regression test was originally written using
`file-name-concat' which was only introduced in Emacs 28.1
(we support 26.1). It now uses a purpose-build Emacs Lisp
replacement.
sp1ff added a commit that referenced this issue Jul 28, 2023
Setting `elfeed-score-rule-stats-file` to a path with intermediate
directories that don't exist will error-out. This fix will at
least attempt to create them.

Also, update the CI workflow & generally prep for the merge
(new versions in docs &c)

As an aside, the regression test was originally written using
`file-name-concat' which was only introduced in Emacs 28.1
(we support 26.1). It now uses a purpose-build Emacs Lisp
replacement.
sp1ff added a commit that referenced this issue Jul 28, 2023
Setting `elfeed-score-rule-stats-file` to a path with intermediate
directories that don't exist will error-out. This fix will at
least attempt to create them.

Also, update the CI workflow & generally prep for the merge
(new versions in docs &c)

As an aside, the regression test was originally written using
`file-name-concat' which was only introduced in Emacs 28.1
(we support 26.1). It now uses a purpose-build Emacs Lisp
replacement.
@sp1ff
Copy link
Owner

sp1ff commented Jul 28, 2023

Should be fixed. Thanks for the report!

@sp1ff sp1ff closed this as completed Jul 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants