Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move test dependency installation to test_cmds list #616

Merged
merged 1 commit into from
Jun 11, 2024

Conversation

jhunkeler
Copy link
Contributor

This change avoids the following error produced by the delivery system when hstcal is tested before any Python packages have been installed.

FileNotFoundError: [Errno 2] No such file or directory: 'pytest'
script returned exit code 1

@jhunkeler jhunkeler requested a review from a team as a code owner June 11, 2024 21:32
Copy link
Contributor

@mdlpstsci mdlpstsci left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great, but I have one question. Should Python be bumped to 3.11 or does it matter in this case?

@jhunkeler
Copy link
Contributor Author

I don't think it matters in this case. For RT runs Python is supposed to be set to the lowest-supported version. The delivery system installs python (not using this file) and executes everything in the test_cmds list.

@jhunkeler jhunkeler merged commit e3d1ac6 into spacetelescope:main Jun 11, 2024
4 checks passed
@jhunkeler jhunkeler deleted the fix-test-cmds branch June 11, 2024 23:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants