Updated and corrected the wf3cte.rst and wf3cte.py files #69
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mdlpstsci
changed the title
cshanahan1
reviewed
Jan 24, 2023
FDauphin
suggested changes
Jan 24, 2023
Removed background documentation on the CTE algorithm which does not belong in this source file. Replaced with URLs for handy reference, particularly so the documentation is not duplicated in multiple locations, and the latest information is available for viewing. Removed support for incorrect items from the source: ability to set the output filename and ability for the code to accept an association table as input. Removal of the output filename modifies the API.
to the documentatio to clarify understanding and correct typos. Question with regard to removal of parameters from the Python interface where addressed. The parameters were effectively no-ops.
mdlpstsci
force-pushed
the
doc_wfc3cte
branch
from
9a3a5a9
to
6101480
Compare
FDauphin
suggested changes
Feb 27, 2023
mdlpstsci
changed the title
|
@cshanahan1 @FDauphin I am starting to prep for a new build release candidate which can include as many WFC3 changes that can fit. This PR needs a re-review. Thanks. |
FDauphin
approved these changes
Apr 21, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Significant updates to the wf3cte.rst file.
Modified the wf3cte.py file as follows:
Removal of the output filename modifies the API.