Fixed the API for calwf3.py #85
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…l, and added an example for usage as no input filename is needed or should be provided if the version is requested. If a filename is provided, it is ignored in this case. Removed the "output" parameter as the underlying C code does not actually support specification of an output filename. Updated comments as appropriate.
zacharyburnett
approved these changes
Aug 16, 2023
|
i just saw this but these were issues i noticed recently too, thanks for fixing! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added the "version" parameter which was missing from the function call for calwf3.py and added an example for usage as no input filename is needed or should be provided if the version is requested. If a filename is provided, it is ignored in this case. Removed the "output" parameter as the underlying C code does not actually support specification of an output filename. Updated comments as appropriate.