Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

扩展了der格式的公钥加载 #5

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

bigsmoke9527
Copy link

在new方法的入参对象里新增了一个key_type的属性,用来区分是pem还是der.
默认是PEM ,可选:DER

@doujiang24
Copy link
Collaborator

@bigsmoke9527 Thanks for your contribution, I'll look into it soon 👍

@whardier
Copy link

whardier commented May 9, 2017

I'm using bigsmoke's code because it supports DER. I can't figure out how to move DER format over to the format C.PEM_read_bio_RSAPublicKey expects.. it was driving me insane. Please merge this.

@whardier
Copy link

whardier commented May 9, 2017

Ideally just constructing off of a modulus and exponent would.. AMAZING.

@spacewander
Copy link
Owner

@bigsmoke9527
Would you have time to rebase your pull request?

@whardier
Copy link

I have one ready - but would prefer @bigsmoke9527 got the love.. I'll wait a week or so and then submit a pull request with @bigsmoke9527 in the comments.

@spacewander
Copy link
Owner

Nice, let's wait a week first.

@spacewander
Copy link
Owner

@whardier
A week has gone. Do you have time to submit the pull request?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants