Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: nokogumbo test suite #2273

Merged
merged 3 commits into from
Jun 19, 2021
Merged

ci: nokogumbo test suite #2273

merged 3 commits into from
Jun 19, 2021

Conversation

flavorjones
Copy link
Member

@flavorjones flavorjones commented Jun 17, 2021

What problem is this PR intended to solve?

Merge the remaining Nokogumbo tests into Nokogiri's test suite.

Have you included adequate test coverage?

Tests are the entire substance of this PR.

Does this change affect the behavior of either the C or the Java implementations?

Notably, these additional tests should only run under CRuby.

@flavorjones flavorjones force-pushed the 2204-nokogumbo-test-suite branch 4 times, most recently from 6ee0e19 to de395c4 Compare June 19, 2021 03:04
@flavorjones flavorjones marked this pull request as ready for review June 19, 2021 04:27
@flavorjones flavorjones merged commit 2516b5a into main Jun 19, 2021
@flavorjones flavorjones deleted the 2204-nokogumbo-test-suite branch June 19, 2021 05:21
@flavorjones flavorjones added this to the v1.12.0 milestone Jun 19, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant