Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix typo in error message #2927

Merged
merged 1 commit into from
Jul 13, 2023
Merged

Fix typo in error message #2927

merged 1 commit into from
Jul 13, 2023

Conversation

anishathalye
Copy link
Contributor

What problem is this PR intended to solve?

Fix a typo in a human-readable error message. I spent a minute trying to figure out what an "Eng tag" was before I realized it was a typo :)

Have you included adequate test coverage?

N/A

Does this change affect the behavior of either the C or the Java implementations?

I think there is no Java analog of this code

@anishathalye anishathalye changed the title Fix typo Fix typo in error message Jul 13, 2023
@flavorjones
Copy link
Member

Thank you! I just kicked off CI.

It's OK to ignore the Appveyor failure, that's due to an unfixed bug in Ruby 2.7.

@flavorjones flavorjones merged commit 3db17e5 into sparklemotion:main Jul 13, 2023
122 checks passed
@flavorjones
Copy link
Member

Thank you!!

@flavorjones
Copy link
Member

Credited you in the changelog at 88091dd

flavorjones added a commit that referenced this pull request Aug 11, 2023
**What problem is this PR intended to solve?**

Backporting changes from:

- #2927
- #2924
- #2951
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants