Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cluster Certificate Management #1308

Merged
merged 13 commits into from
May 24, 2023
Merged

Cluster Certificate Management #1308

merged 13 commits into from
May 24, 2023

Conversation

karl-cardenas-coding
Copy link
Contributor

@karl-cardenas-coding karl-cardenas-coding commented May 22, 2023 •
edited
Loading

Describe the Change

This PR documents how users can renew their cluster's PKI certificates through Palette.

Review Changes

💻 Preview URL

🎫 Jira Ticket

@karl-cardenas-coding karl-cardenas-coding added the documentation Improvements or additions to documentation label May 22, 2023
@spectro-prow spectro-prow added the do-not-merge/work-in-progress Work in-progress. DO NOT MERGE label May 22, 2023
@karl-cardenas-coding karl-cardenas-coding changed the title docs: reference page for pki cert mgmt Cluster Certificate Management May 22, 2023
@netlify
Copy link

netlify bot commented May 22, 2023 •
edited
Loading

✅ Deploy Preview for docs-spectrocloud ready!

Name Link
🔨 Latest commit 8a4caa1
🔍 Latest deploy log https://app.netlify.com/sites/docs-spectrocloud/deploys/646e8abab426ba00083eaf28
😎 Deploy Preview https://deploy-preview-1308--docs-spectrocloud.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@karl-cardenas-coding karl-cardenas-coding marked this pull request as ready for review May 23, 2023 21:56
@karl-cardenas-coding karl-cardenas-coding requested a review from a team as a code owner May 23, 2023 21:56
@karl-cardenas-coding karl-cardenas-coding requested review from ritawatson, rahulhazra97 and sudkul87 and removed request for a team May 23, 2023 21:56
@spectrocloud spectrocloud deleted a comment from spectro-prow May 23, 2023
rahulhazra97
rahulhazra97 approved these changes May 24, 2023
View reviewed changes
Copy link
Contributor

@rahulhazra97 rahulhazra97 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some minor changes.

karl-cardenas-coding and others added 2 commits May 24, 2023 08:52
@karl-cardenas-coding @rahulhazra97
Apply suggestions from code review
8072d7d 
Co-authored-by: Rahul Hazra <126905240+rahulhazra97@users.noreply.github.com>
@github-actions
Optimised images with calibre/image-actions
e0602d6
@github-actions
Copy link
Contributor

Images automagically compressed by Calibre's image-actions ✨

Compression reduced images by 27.5%, saving 188.52 KB.

Filename Before After Improvement Visual comparison
assets/docs/images/clusters_cluster-management_certificate-management_certificate-renew-page.png 196.24 KB 137.96 KB -29.7% View diff
assets/docs/images/clusters_cluster-management_certificate-management_cluster-details-page.png 248.83 KB 180.79 KB -27.3% View diff
assets/docs/images/clusters_cluster-management_certificate-management_control-plane-only-change.png 239.73 KB 177.52 KB -26.0% View diff

337 images did not require optimisation.

ritawatson
ritawatson approved these changes May 24, 2023
View reviewed changes
Copy link
Contributor

@ritawatson ritawatson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a few comments. The sentence to replace REPLACE_ME uses "place" three times, so I offered alternative wording throughout.

LGTM

content/docs/04-clusters/06-cluster-management/02.5-certificate-management.md Outdated Show resolved Hide resolved
content/docs/04-clusters/06-cluster-management/02.5-certificate-management.md Outdated Show resolved Hide resolved
content/docs/04-clusters/06-cluster-management/02.5-certificate-management.md Outdated Show resolved Hide resolved
content/docs/04-clusters/06-cluster-management/02.5-certificate-management.md Outdated

<InfoBox>

You can upgrade the Kubernetes version of a cluster by updating the Kubernetes layer of the [cluster profile](/cluster-profiles) and applying the cluster profile update to the cluster.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As line 48 talks about updating the pack version, here's another good link to add or to replace the cluster profile link:

For guidelines on updating pack versions, review Update the Pack Version.

I used it in the maintenance policy doc, which it talks about updating the pack version when your profile uses a disabled or deleted pack.

content/docs/04-clusters/06-cluster-management/02.5-certificate-management.md Outdated Show resolved Hide resolved
content/docs/04-clusters/06-cluster-management/02.5-certificate-management.md Outdated Show resolved Hide resolved
content/docs/04-clusters/06-cluster-management/02.5-certificate-management.md Outdated Show resolved Hide resolved
content/docs/04-clusters/06-cluster-management/02.5-certificate-management.md Outdated Show resolved Hide resolved
content/docs/04-clusters/06-cluster-management/02.5-certificate-management.md Outdated Show resolved Hide resolved
content/docs/04-clusters/06-cluster-management/02.5-certificate-management.md Outdated Show resolved Hide resolved
ritawatson
ritawatson approved these changes May 24, 2023
View reviewed changes
Copy link
Contributor

@ritawatson ritawatson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a few comments. The sentence to replace REPLACE_ME uses "place" three times, so I offered alternative wording throughout.

LGTM

karl-cardenas-coding and others added 2 commits May 24, 2023 15:06
@karl-cardenas-coding @ritawatson
Apply suggestions from code review
c01e990 
Co-authored-by: Rita Watson <117382432+ritawatson@users.noreply.github.com>
@karl-cardenas-coding
Merge branch 'master' into certificate-behavior
8a4caa1
@karl-cardenas-coding karl-cardenas-coding merged commit 5cbb157 into master May 24, 2023
@karl-cardenas-coding karl-cardenas-coding deleted the certificate-behavior branch May 24, 2023 22:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@github-actions GitHub Actions github-actions left review comments

@ritawatson ritawatson ritawatson approved these changes

@rahulhazra97 rahulhazra97 rahulhazra97 approved these changes

@sudkul87 sudkul87 Awaiting requested review from sudkul87 sudkul87 is a code owner automatically assigned from spectrocloud/docs-education

@sadysnaat sadysnaat Awaiting requested review from sadysnaat

Assignees
No one assigned
Labels
do-not-merge/work-in-progress Work in-progress. DO NOT MERGE documentation Improvements or additions to documentation
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@karl-cardenas-coding @ritawatson @rahulhazra97 @spectro-prow