DOC-783 Add hideClipboard functionality #1355
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for docs-spectrocloud ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
karl-cardenas-coding
requested review from
karl-cardenas-coding,
rahulhazra97 and
sudkul87
and removed request for
a team
karl-cardenas-coding
approved these changes
Jun 7, 2023
There was a problem hiding this comment.
@nagesh161007 I'm approving this PR because the changes look good. I have some minor suggestions for the README.
|
Images automagically compressed by Calibre's image-actions ✨ Compression reduced images by 49.7%, saving 13.05 KB.
344 images did not require optimisation. |
sudkul87
pushed a commit
that referenced
this pull request
Jun 8, 2023
* chore : add hideClipboard functionality * Optimised images with calibre/image-actions * chore : fix ci/cd * chore : remove unsued variables in test case * chore:fix review comments * Optimised images with calibre/image-actions * chore: remove white space --------- Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
karl-cardenas-coding
added a commit
that referenced
this pull request
Jun 12, 2023
* docs: improve the intro * Optimised images with calibre/image-actions * Apply suggestions from code review round 1 - part 1 Co-authored-by: Karl Cardenas <karl@spectrocloud.com> * docs: apply suggestions from code review round 1 * docs: typo * docs: add basic and advanced * docs: add Dockerfile customization * docs:typo * docs:typo again * docs: add docker push * docs: remove color highlight * docs: language cleanup * Apply suggestions from code review round 2 Co-authored-by: Karl Cardenas <karl@spectrocloud.com> * docs: address feedback suggestions * docs: add docker hub prereq * Apply suggestions from code review round 3 Co-authored-by: Karl Cardenas <karl@spectrocloud.com> * docs: apply feedback suggestions * docs: update arguments * docs: finishing touch * docs: language cleanup * docs: minor language fixes and updated URLs * docs: update image and URL * Optimised images with calibre/image-actions * docs: minor Edge fixes * docs: fixed indentation on advanced section #12 * docs: address bug-bash-session feedback * docs: grammar fix * Optimised images with calibre/image-actions * docs: update metadescription * docs: remove vi * Optimised images with calibre/image-actions * docs: language clean up * docs:typo * Apply suggestions from code review Co-authored-by: Karl Cardenas <karl@spectrocloud.com> * docs: add suggestions from review * docs: fix conflict and change tabs * docs: update the diagram * Optimised images with calibre/image-actions * DOC-783 Add hideClipboard functionality (#1355) * chore : add hideClipboard functionality * Optimised images with calibre/image-actions * chore : fix ci/cd * chore : remove unsued variables in test case * chore:fix review comments * Optimised images with calibre/image-actions * chore: remove white space --------- Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> * docs: change tabs * docs: add hideClipboard * docs: typo * Apply suggestions from code review * docs: concept clarification and language fixes * Optimised images with calibre/image-actions * chore: retrigger build * docs: updates based on CanvOS changes * docs: final update --------- Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> Co-authored-by: Karl Cardenas <karl@spectrocloud.com> Co-authored-by: Nageshwara sairam <113401242+nagesh161007@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe the Change
This pull request introduces a new feature called "hideClipboard" in markdown files, which allows the copy button for code snippets to be hidden.
By default, the copy button will be displayed. However, if desired, users can override this default behavior by specifying the "hideClipboard" option when working with markdown files.
Setup test environment using jest and react testing library.
Added unit test cases for Pre component and added test step in Github CI/CD actions
Example
Review Changes
💻 Add Preview URL
🎫 Jira Ticket