Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

AWS Cluster Updates #1410

Merged
merged 7 commits into from
Jul 11, 2023
Merged

AWS Cluster Updates #1410

merged 7 commits into from
Jul 11, 2023

Conversation

karl-cardenas-coding
Copy link
Contributor

@karl-cardenas-coding karl-cardenas-coding commented Jul 10, 2023

Describe the Change

This PR adds new content to the AWS section and addresses minor feedback.

Review Changes

💻 Preview URL

🎫 DOC-813
🎫 PCP-1334

@karl-cardenas-coding karl-cardenas-coding requested a review from a team as a code owner July 10, 2023 16:06
@karl-cardenas-coding karl-cardenas-coding requested review from ritawatson and sudkul87 and removed request for a team July 10, 2023 16:06
@karl-cardenas-coding karl-cardenas-coding changed the title docs: DOC-813 added steps for additional security groups AWS Cluster Updates Jul 10, 2023
@netlify
Copy link

netlify bot commented Jul 10, 2023

Deploy Preview for docs-spectrocloud ready!

Name Link
🔨 Latest commit e487f74
🔍 Latest deploy log https://app.netlify.com/sites/docs-spectrocloud/deploys/64ad7fc119246900082d0a24
😎 Deploy Preview https://deploy-preview-1410--docs-spectrocloud.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@karl-cardenas-coding karl-cardenas-coding marked this pull request as draft July 10, 2023 16:23
@karl-cardenas-coding karl-cardenas-coding marked this pull request as ready for review July 10, 2023 20:50
@karl-cardenas-coding karl-cardenas-coding changed the base branch from master to release-4.0 July 10, 2023 20:54
@karl-cardenas-coding karl-cardenas-coding changed the base branch from release-4.0 to master July 10, 2023 21:33

16. Review the settings summary and click on **Finish Configuration** to deploy the cluster. Provisioning IaaS clusters can take 15 - 30 minutes depending on the cluster profile and the node pool configuration.
14. If you checked the **Static Placement** box in the **Cluster config** page, you can specify additional AWS [security groups](https://docs.aws.amazon.com/vpc/latest/userguide/security-groups.html) to apply to the worker group nodes. Use the **Additional Security Groups (Optional)** drop-down Menu to select additional security groups.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Our style is to boldface drop-down Menu. Can this be reworded to get around boldfacing "Additional Security Groups (Optional)"?

Copy link
Contributor

@ritawatson ritawatson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a style question. Otherwise, LGTM.

@karl-cardenas-coding karl-cardenas-coding merged commit a99adda into master Jul 11, 2023
9 checks passed
karl-cardenas-coding added a commit that referenced this pull request Jul 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants