Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Document OIDC options for Spectro VM Dashboard: PEM-2283 #1526

Merged

Conversation

ritawatson
Copy link
Contributor

@ritawatson ritawatson commented Sep 7, 2023

Describe the Change

This PR adds a doc to Configure OIDC options (Preview) that allow Palette to display the VM Dashboard.

The PR also cleans up formatting after the Docusaurus migration.

Recently, descriptions were added to address how dashboard access is based on the OIDC option the user selects:

CleanShot 2023-09-26 at 17 09 30

Review Changes

💻 Preview

🎫 Jira Ticket

@ritawatson ritawatson added documentation Improvements or additions to documentation auto-backport Enable backport backport-version-4-0 Backport change to version 4.0 labels Sep 7, 2023
@ritawatson
Copy link
Contributor Author

This is work in progress - do not merge.

@ritawatson ritawatson changed the title Drafted possible additions for OIDC, added links Document OIDC options for Spectro VM Dashboard: PEM-2283 Sep 7, 2023
@netlify
Copy link

netlify bot commented Sep 7, 2023

Deploy Preview for docs-spectrocloud ready!

Name Link
🔨 Latest commit 71ecb0f
🔍 Latest deploy log https://app.netlify.com/sites/docs-spectrocloud/deploys/6514bc14c4e9480008b186a8
😎 Deploy Preview https://deploy-preview-1526--docs-spectrocloud.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@ritawatson ritawatson marked this pull request as ready for review September 13, 2023 20:21
@ritawatson ritawatson requested a review from a team as a code owner September 13, 2023 20:21
Copy link
Contributor

@cloudmaniac cloudmaniac left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, I only provided a single suggestion. I'll let @tiwarisumit3 answer your comment in PEM-2283.

Copy link
Contributor

@karl-cardenas-coding karl-cardenas-coding left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

URLs need to be corrected, along with merge conflicts.

@ritawatson ritawatson merged commit a0e1f84 into master Sep 28, 2023
8 checks passed
@ritawatson ritawatson deleted the document-oidc-options-for-spectro-vm-dashboard-pem-2283 branch September 28, 2023 00:10
vault-token-factory-spectrocloud bot pushed a commit that referenced this pull request Sep 28, 2023
* Drafted possible additions for OIDC, added links

* Added  'Configure OIDC Options'

* Removed extra breaks

* Uncommented paragraph re OIDC roles

* Revised a couple sentences.

* Add desc of dshbrd access based on OIDC selection

* Updated the doc description

* Fixed slightly awk wording

* Fixed URLs

* Inserted an omitted word

* Fix one more URL

(cherry picked from commit a0e1f84)
@vault-token-factory-spectrocloud
Copy link
Contributor

💚 All backports created successfully

Status Branch Result
version-4-0

Note: Successful backport PRs will be merged automatically after passing CI.

Questions ?

Please refer to the Backport tool documentation and see the Github Action logs for details

ritawatson added a commit that referenced this pull request Sep 28, 2023
* Drafted possible additions for OIDC, added links

* Added  'Configure OIDC Options'

* Removed extra breaks

* Uncommented paragraph re OIDC roles

* Revised a couple sentences.

* Add desc of dshbrd access based on OIDC selection

* Updated the doc description

* Fixed slightly awk wording

* Fixed URLs

* Inserted an omitted word

* Fix one more URL

(cherry picked from commit a0e1f84)

Co-authored-by: Rita Watson <117382432+ritawatson@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
auto-backport Enable backport backport-version-4-0 Backport change to version 4.0 documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants