-
Notifications
You must be signed in to change notification settings - Fork 36
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update registries-and-packs.md #1543
Conversation
WIP - as part of an attempt to consolidate terminology around packs, layers, and cluster profiles, this is a quick test PR based on https://docs.google.com/presentation/d/1w5PSUgyNH59Tz0AIPrBZ7UwxO9j5M7dZKdJhEIBHdr0/edit#slide=id.p31
✅ Deploy Preview for docs-spectrocloud ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some minor suggestions. Otherwise LGTM.
@@ -13,19 +13,19 @@ sidebar_custom_props: | |||
# Packs | |||
|
|||
|
|||
A **Cluster Profile** is made up of preconfigured layers, each of which is called a pack. In other words, **Packs** are the building block of a cluster profile to create layers such as operating systems, Kubernetes, network, storage, and add-ons. Packs can be broadly categorized into two types: | |||
A **Cluster Profile** is made up of layers, each of which is created using a pack. In other words, **Packs** are the building block of a cluster profile to create layers such as operating systems, Kubernetes, network, storage, and add-ons. Packs can be broadly categorized into two types: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I suggest omitting the second sentence that starts "In other words...". The first sentence says it clearly, and the definition of Infrastructure packs is below.
Co-authored-by: Rita Watson <117382432+ritawatson@users.noreply.github.com>
@ritawatson have finished accepting the changes |
💚 All backports created successfully
Note: Successful backport PRs will be merged automatically after passing CI. Questions ?Please refer to the Backport tool documentation and see the Github Action logs for details |
WIP - as part of an attempt to consolidate terminology around packs, layers, and cluster profiles, this is a quick test PR based on https://docs.google.com/presentation/d/1w5PSUgyNH59Tz0AIPrBZ7UwxO9j5M7dZKdJhEIBHdr0/edit#slide=id.p31
Specifically, layers exist in cluster profiles, and are formed using packs. Also, the terms "core" and "infrastructure" packs are used interchangeably, and we should consolidate onto only one term. At present, my view is that will be "infrastructure".
Describe the Change
This PR .....
Review Changes
💻 Add Preview URL
🎫 Jira Ticket