Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update registries-and-packs.md #1543

Merged
merged 4 commits into from
Sep 13, 2023
Merged

Conversation

antongisli
Copy link
Contributor

WIP - as part of an attempt to consolidate terminology around packs, layers, and cluster profiles, this is a quick test PR based on https://docs.google.com/presentation/d/1w5PSUgyNH59Tz0AIPrBZ7UwxO9j5M7dZKdJhEIBHdr0/edit#slide=id.p31

Specifically, layers exist in cluster profiles, and are formed using packs. Also, the terms "core" and "infrastructure" packs are used interchangeably, and we should consolidate onto only one term. At present, my view is that will be "infrastructure".

Describe the Change

This PR .....

Review Changes

💻 Add Preview URL

🎫 Jira Ticket

WIP - as part of an attempt to consolidate terminology around packs, layers, and cluster profiles, this is a quick test PR based on https://docs.google.com/presentation/d/1w5PSUgyNH59Tz0AIPrBZ7UwxO9j5M7dZKdJhEIBHdr0/edit#slide=id.p31
@netlify
Copy link

netlify bot commented Sep 12, 2023

Deploy Preview for docs-spectrocloud ready!

Name Link
🔨 Latest commit 1460cc2
🔍 Latest deploy log https://app.netlify.com/sites/docs-spectrocloud/deploys/6501f482cefe510008cad9df
😎 Deploy Preview https://deploy-preview-1543--docs-spectrocloud.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link
Contributor

@ritawatson ritawatson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some minor suggestions. Otherwise LGTM.

@@ -13,19 +13,19 @@ sidebar_custom_props:
# Packs


A **Cluster Profile** is made up of preconfigured layers, each of which is called a pack. In other words, **Packs** are the building block of a cluster profile to create layers such as operating systems, Kubernetes, network, storage, and add-ons. Packs can be broadly categorized into two types:
A **Cluster Profile** is made up of layers, each of which is created using a pack. In other words, **Packs** are the building block of a cluster profile to create layers such as operating systems, Kubernetes, network, storage, and add-ons. Packs can be broadly categorized into two types:
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I suggest omitting the second sentence that starts "In other words...". The first sentence says it clearly, and the definition of Infrastructure packs is below.

@karl-cardenas-coding karl-cardenas-coding added backport-version-4-0 Backport change to version 4.0 auto-backport Enable backport backport-version-3-4 Backport change to version 3.4 labels Sep 13, 2023
antongisli and others added 2 commits September 13, 2023 17:41
Co-authored-by: Rita Watson <117382432+ritawatson@users.noreply.github.com>
@antongisli
Copy link
Contributor Author

@ritawatson have finished accepting the changes

@karl-cardenas-coding karl-cardenas-coding merged commit 0f15f05 into master Sep 13, 2023
4 checks passed
@karl-cardenas-coding karl-cardenas-coding deleted the antongisli-patch-2 branch September 13, 2023 17:59
@github-actions
Copy link
Contributor

💚 All backports created successfully

Status Branch Result
version-4-0
version-3-4

Note: Successful backport PRs will be merged automatically after passing CI.

Questions ?

Please refer to the Backport tool documentation and see the Github Action logs for details

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
auto-backport Enable backport backport-version-3-4 Backport change to version 3.4 backport-version-4-0 Backport change to version 4.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants