Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: updated broken URL and added missing release note PCP-1888 #1699

Merged
merged 4 commits into from
Oct 23, 2023

Conversation

karl-cardenas-coding
Copy link
Contributor

@karl-cardenas-coding karl-cardenas-coding commented Oct 23, 2023

Describe the Change

This PR fixes the broken URL reported in URL report and fixes some minor issues reported.

  • Incorrect VerteX support for Azure Gov
  • Added missing release note for Azure upgrade channels.

Review Changes

💻 Preview URL

🎫 PCP-1888https://spectrocloud.atlassian.net/browse/PCP-1888)

@karl-cardenas-coding karl-cardenas-coding added auto-backport Enable backport backport-version-4-1 Backport change to version 4.1 labels Oct 23, 2023
@karl-cardenas-coding karl-cardenas-coding requested a review from a team as a code owner October 23, 2023 21:29
@netlify
Copy link

netlify bot commented Oct 23, 2023

Deploy Preview for docs-spectrocloud ready!

Name Link
🔨 Latest commit f6f2406
🔍 Latest deploy log https://app.netlify.com/sites/docs-spectrocloud/deploys/6536f9a024a1a40008b8246d
😎 Deploy Preview https://deploy-preview-1699--docs-spectrocloud.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link
Contributor

@ritawatson ritawatson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One suggestion. Otherwise, LGTM.

Co-authored-by: Rita Watson <117382432+ritawatson@users.noreply.github.com>
@karl-cardenas-coding karl-cardenas-coding merged commit 53df946 into master Oct 23, 2023
8 checks passed
@karl-cardenas-coding karl-cardenas-coding deleted the content-addition-url branch October 23, 2023 23:38
vault-token-factory-spectrocloud bot pushed a commit that referenced this pull request Oct 23, 2023
* docs: updated broken URL and added missing release note PCP-1888

* docs: vale feedback

* Apply suggestions from code review

Co-authored-by: Rita Watson <117382432+ritawatson@users.noreply.github.com>

---------

Co-authored-by: Rita Watson <117382432+ritawatson@users.noreply.github.com>
(cherry picked from commit 53df946)
@vault-token-factory-spectrocloud
Copy link
Contributor

💚 All backports created successfully

Status Branch Result
version-4-1

Note: Successful backport PRs will be merged automatically after passing CI.

Questions ?

Please refer to the Backport tool documentation and see the Github Action logs for details

karl-cardenas-coding added a commit that referenced this pull request Oct 24, 2023
…) (#1700)

* docs: updated broken URL and added missing release note PCP-1888

* docs: vale feedback

* Apply suggestions from code review

Co-authored-by: Rita Watson <117382432+ritawatson@users.noreply.github.com>

---------

Co-authored-by: Rita Watson <117382432+ritawatson@users.noreply.github.com>
(cherry picked from commit 53df946)

Co-authored-by: Karl Cardenas <karl@spectrocloud.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
auto-backport Enable backport backport-version-4-1 Backport change to version 4.1
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants