Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs:PE-2831 provision static IP #1726

Merged
merged 8 commits into from
Oct 30, 2023
Merged

docs:PE-2831 provision static IP #1726

merged 8 commits into from
Oct 30, 2023

Conversation

lennessyy
Copy link
Contributor

@lennessyy lennessyy commented Oct 30, 2023 •
edited
Loading

Document the Static IP provision changes for Edge Native cluster setup

Describe the Change

This PR adds the steps to provision a static IP address for Edge hosts when a cluster is first created and when someone adds an Edge host to an existing cluster.

Review Changes

💻 Preview - Cluster Deployment

🎫 PE-2831

@netlify
Copy link

netlify bot commented Oct 30, 2023 •
edited
Loading

✅ Deploy Preview for docs-spectrocloud ready!

Name Link
🔨 Latest commit d8356a6
🔍 Latest deploy log https://app.netlify.com/sites/docs-spectrocloud/deploys/654025cd02f1c5000785a3c3
😎 Deploy Preview https://deploy-preview-1726--docs-spectrocloud.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@lennessyy lennessyy self-assigned this Oct 30, 2023
@lennessyy lennessyy added auto-backport Enable backport backport-version-4-1 Backport change to version 4.1 labels Oct 30, 2023
@lennessyy lennessyy marked this pull request as ready for review October 30, 2023 19:42
@lennessyy lennessyy requested a review from a team as a code owner October 30, 2023 19:42
caroldelwing
caroldelwing approved these changes Oct 30, 2023
View reviewed changes
Copy link
Contributor

@caroldelwing caroldelwing left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A small suggestion.

docs/docs-content/clusters/edge/site-deployment/site-installation/cluster-deployment.md Outdated Show resolved Hide resolved
karl-cardenas-coding
karl-cardenas-coding requested changes Oct 30, 2023
View reviewed changes
Copy link
Contributor

@karl-cardenas-coding karl-cardenas-coding left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes look good overall, just some action items that need to be addressed.

docs/docs-content/clusters/edge/site-deployment/site-installation/cluster-deployment.md Outdated Show resolved Hide resolved
docs/docs-content/clusters/edge/site-deployment/site-installation/cluster-deployment.md Outdated Show resolved Hide resolved
docs/docs-content/clusters/edge/site-deployment/site-installation/cluster-deployment.md Outdated Show resolved Hide resolved
docs/docs-content/clusters/edge/site-deployment/site-installation/cluster-deployment.md Outdated Show resolved Hide resolved
karl-cardenas-coding
karl-cardenas-coding approved these changes Oct 30, 2023
View reviewed changes
Copy link
Contributor

@karl-cardenas-coding karl-cardenas-coding left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great, just some last quality of life suggestions.

docs/docs-content/clusters/edge/site-deployment/site-installation/cluster-deployment.md Outdated Show resolved Hide resolved
docs/docs-content/clusters/edge/site-deployment/site-installation/cluster-deployment.md Outdated Show resolved Hide resolved
docs/docs-content/clusters/edge/site-deployment/site-installation/cluster-deployment.md Outdated Show resolved Hide resolved
@lennessyy lennessyy enabled auto-merge (squash) October 30, 2023 21:57
@lennessyy lennessyy merged commit bf81713 into master Oct 30, 2023
8 checks passed
@lennessyy lennessyy deleted the static-ip-provision branch October 30, 2023 22:09
vault-token-factory-spectrocloud bot pushed a commit that referenced this pull request Oct 30, 2023
@lennessyy
docs:PE-2831 document steps to provision static IP for edge hosts (#1726
cde4eb9 
)

* docs:PE-2831 provision static IP
 for edge hosts

* Bold UI elements

* Incorporate feedback

* Fix vale comments

* delete redundant toc

* docs: remove reference to internet and fix tabbed callouts

---------

Co-authored-by: Lenny Chen <lenny.chen@spectrocloud.com>
(cherry picked from commit bf81713)
@vault-token-factory-spectrocloud vault-token-factory-spectrocloud bot mentioned this pull request Oct 30, 2023
Merged
@vault-token-factory-spectrocloud
Copy link
Contributor

💚 All backports created successfully

Status Branch Result
✅ version-4-1

Note: Successful backport PRs will be merged automatically after passing CI.

Questions ?

Please refer to the Backport tool documentation and see the Github Action logs for details

lennessyy added a commit that referenced this pull request Oct 30, 2023
@vault-token-factory-spectrocloud @lennessyy
docs:PE-2831 document steps to provision static IP for edge hosts (#1726
6de1ccb 
) (#1728)

* docs:PE-2831 provision static IP
 for edge hosts

* Bold UI elements

* Incorporate feedback

* Fix vale comments

* delete redundant toc

* docs: remove reference to internet and fix tabbed callouts

---------

Co-authored-by: Lenny Chen <lenny.chen@spectrocloud.com>
(cherry picked from commit bf81713)

Co-authored-by: Lenny Chen <55669665+lennessyy@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@github-actions GitHub Actions github-actions left review comments

@vipsharm vipsharm vipsharm approved these changes

@karl-cardenas-coding karl-cardenas-coding karl-cardenas-coding approved these changes

@caroldelwing caroldelwing caroldelwing approved these changes

@ritawatson ritawatson Awaiting requested review from ritawatson ritawatson is a code owner automatically assigned from spectrocloud/docs-education

Assignees

@lennessyy lennessyy

Labels
auto-backport Enable backport backport-version-4-1 Backport change to version 4.1
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@lennessyy @vipsharm @karl-cardenas-coding @caroldelwing