Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: minor touches DOC-910 DOC-911 #1779

Merged
merged 3 commits into from
Nov 9, 2023
Merged

Conversation

karl-cardenas-coding
Copy link
Contributor

@karl-cardenas-coding karl-cardenas-coding commented Nov 9, 2023

Describe the Change

This PR addresses two minor issues reported in Slack.

Review Changes

💻 Preview URL

🎫 DOC-911
🎫 DOC-910

@karl-cardenas-coding karl-cardenas-coding added backport-version-4-0 Backport change to version 4.0 auto-backport Enable backport backport-version-3-4 Backport change to version 3.4 backport-version-4-1 Backport change to version 4.1 labels Nov 9, 2023
@karl-cardenas-coding karl-cardenas-coding requested a review from a team as a code owner November 9, 2023 20:42
Copy link

netlify bot commented Nov 9, 2023

Deploy Preview for docs-spectrocloud ready!

Name Link
🔨 Latest commit d81d832
🔍 Latest deploy log https://app.netlify.com/sites/docs-spectrocloud/deploys/654d4f9feef6740007931d83
😎 Deploy Preview https://deploy-preview-1779--docs-spectrocloud.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Co-authored-by: Lenny Chen <55669665+lennessyy@users.noreply.github.com>
@karl-cardenas-coding karl-cardenas-coding merged commit 8ea4e21 into master Nov 9, 2023
8 checks passed
@karl-cardenas-coding karl-cardenas-coding deleted the docs-fixes-11-9 branch November 9, 2023 21:50
vault-token-factory-spectrocloud bot pushed a commit that referenced this pull request Nov 9, 2023
* docs: minor touches DOC-910 DOC-911

* docs: removed clipboard from output

* Apply suggestions from code review

Co-authored-by: Lenny Chen <55669665+lennessyy@users.noreply.github.com>

---------

Co-authored-by: Lenny Chen <55669665+lennessyy@users.noreply.github.com>
(cherry picked from commit 8ea4e21)
vault-token-factory-spectrocloud bot pushed a commit that referenced this pull request Nov 9, 2023
* docs: minor touches DOC-910 DOC-911

* docs: removed clipboard from output

* Apply suggestions from code review

Co-authored-by: Lenny Chen <55669665+lennessyy@users.noreply.github.com>

---------

Co-authored-by: Lenny Chen <55669665+lennessyy@users.noreply.github.com>
(cherry picked from commit 8ea4e21)
vault-token-factory-spectrocloud bot pushed a commit that referenced this pull request Nov 9, 2023
* docs: minor touches DOC-910 DOC-911

* docs: removed clipboard from output

* Apply suggestions from code review

Co-authored-by: Lenny Chen <55669665+lennessyy@users.noreply.github.com>

---------

Co-authored-by: Lenny Chen <55669665+lennessyy@users.noreply.github.com>
(cherry picked from commit 8ea4e21)
@vault-token-factory-spectrocloud
Copy link
Contributor

💚 All backports created successfully

Status Branch Result
version-4-0
version-3-4
version-4-1

Note: Successful backport PRs will be merged automatically after passing CI.

Questions ?

Please refer to the Backport tool documentation and see the Github Action logs for details

karl-cardenas-coding added a commit that referenced this pull request Nov 9, 2023
* docs: minor touches DOC-910 DOC-911

* docs: removed clipboard from output

* Apply suggestions from code review

Co-authored-by: Lenny Chen <55669665+lennessyy@users.noreply.github.com>

---------

Co-authored-by: Lenny Chen <55669665+lennessyy@users.noreply.github.com>
(cherry picked from commit 8ea4e21)

Co-authored-by: Karl Cardenas <karl@spectrocloud.com>
karl-cardenas-coding added a commit that referenced this pull request Nov 9, 2023
* docs: minor touches DOC-910 DOC-911

* docs: removed clipboard from output

* Apply suggestions from code review

Co-authored-by: Lenny Chen <55669665+lennessyy@users.noreply.github.com>

---------

Co-authored-by: Lenny Chen <55669665+lennessyy@users.noreply.github.com>
(cherry picked from commit 8ea4e21)

Co-authored-by: Karl Cardenas <karl@spectrocloud.com>
karl-cardenas-coding added a commit that referenced this pull request Nov 9, 2023
* docs: minor touches DOC-910 DOC-911

* docs: removed clipboard from output

* Apply suggestions from code review

Co-authored-by: Lenny Chen <55669665+lennessyy@users.noreply.github.com>

---------

Co-authored-by: Lenny Chen <55669665+lennessyy@users.noreply.github.com>
(cherry picked from commit 8ea4e21)

Co-authored-by: Karl Cardenas <karl@spectrocloud.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
auto-backport Enable backport backport-version-3-4 Backport change to version 3.4 backport-version-4-0 Backport change to version 4.0 backport-version-4-1 Backport change to version 4.1
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants