-
Notifications
You must be signed in to change notification settings - Fork 36
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weβll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs:add command to delete packer cache and merge the .packerenv and β¦ #1791
Conversation
β Deploy Preview for docs-spectrocloud ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
I keep getting this error:
If I go inside the docker container and run Don't quite understand why this is happening. I tried googling this error and wasn't really able to find much about it that seems to apply to us. Do you have any ideas? @karl-cardenas-coding |
|
That does seem to be the case. I tried to have it echo the variable and it did not give me a response. I'll look into it more this week |
Try wrapping the sh command in single to ticks, and use double quotes to escape the env variable.
|
β¦trocloud/librarium into delete-packer-cache-vcenter
docs/docs-content/clusters/edge/site-deployment/deploy-cluster.md
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Changes look good @lennessyy just some minor suggestions . Let's make sure the tutorial image is released and available before we merge the PR.
docs/docs-content/clusters/edge/site-deployment/deploy-cluster.md
Outdated
Show resolved
Hide resolved
docs/docs-content/clusters/edge/site-deployment/deploy-cluster.md
Outdated
Show resolved
Hide resolved
Co-authored-by: Karl Cardenas <karl@spectrocloud.com>
#1791) * docs:add command to delete packer cache and merge the .packerenv and .goenv file * uncombine .goenv and .packerenv * fix typo * added command to source the setenv.sh first * use absolute path * docs: add command to delete packer cache * add delete cache commands and explain the file additions * fix typo * Apply suggestions from code review Co-authored-by: Karl Cardenas <karl@spectrocloud.com> --------- Co-authored-by: Lenny Chen <lenny.chen@spectrocloud.com> Co-authored-by: Karl Cardenas <karl@spectrocloud.com> (cherry picked from commit b04a9dd)
π All backports created successfully
Note: Successful backport PRs will be merged automatically after passing CI. Questions ?Please refer to the Backport tool documentation and see the Github Action logs for details |
#1791) (#1815) * docs:add command to delete packer cache and merge the .packerenv and .goenv file * uncombine .goenv and .packerenv * fix typo * added command to source the setenv.sh first * use absolute path * docs: add command to delete packer cache * add delete cache commands and explain the file additions * fix typo * Apply suggestions from code review Co-authored-by: Karl Cardenas <karl@spectrocloud.com> --------- Co-authored-by: Lenny Chen <lenny.chen@spectrocloud.com> Co-authored-by: Karl Cardenas <karl@spectrocloud.com> (cherry picked from commit b04a9dd) Co-authored-by: Lenny Chen <55669665+lennessyy@users.noreply.github.com>
Describe the Change
This PR adds the command to delete packer cache before the user builds and uploads their VM templates.
Review Changes
π» Add Preview URL
π« Jira Ticket