Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: add k3s pack doc #1792

Merged
merged 31 commits into from
Nov 17, 2023
Merged

docs: add k3s pack doc #1792

merged 31 commits into from
Nov 17, 2023

Conversation

lennessyy
Copy link
Contributor

@lennessyy lennessyy commented Nov 11, 2023

Describe the Change

This PR adds a document on the K3s pack page.

Review Changes

💻 K3s

🎫 Jira Ticket

Copy link

netlify bot commented Nov 11, 2023

Deploy Preview for docs-spectrocloud ready!

Name Link
🔨 Latest commit 4776409
🔍 Latest deploy log https://app.netlify.com/sites/docs-spectrocloud/deploys/6557b2949de517000841dab9
😎 Deploy Preview https://deploy-preview-1792--docs-spectrocloud.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@lennessyy lennessyy changed the title K3s pack doc docs: add k3s pack doc Nov 13, 2023
@lennessyy
Copy link
Contributor Author

I will add the other versions in the document once we decide that the content is right

@lennessyy lennessyy marked this pull request as ready for review November 13, 2023 23:57
@lennessyy lennessyy requested a review from a team as a code owner November 13, 2023 23:57
@lennessyy lennessyy added auto-backport Enable backport 4.1 4.1 Release 4.0 4.0 Release 4.2 4.2 Release labels Nov 13, 2023
docs/docs-content/integrations/k3s.md Outdated Show resolved Hide resolved
docs/docs-content/integrations/k3s.md Outdated Show resolved Hide resolved
docs/docs-content/integrations/k3s.md Show resolved Hide resolved
docs/docs-content/integrations/k3s.md Outdated Show resolved Hide resolved
docs/docs-content/integrations/k3s.md Outdated Show resolved Hide resolved
docs/docs-content/integrations/k3s.md Outdated Show resolved Hide resolved
docs/docs-content/integrations/k3s.md Show resolved Hide resolved
docs/docs-content/integrations/k3s.md Outdated Show resolved Hide resolved
@lennessyy lennessyy removed 4.0 4.0 Release 4.1 4.1 Release 4.2 4.2 Release labels Nov 13, 2023
@lennessyy lennessyy marked this pull request as draft November 14, 2023 22:09
@lennessyy lennessyy added backport-version-4-1 Backport change to version 4.1 backport-version-4-0 Backport change to version 4.0 labels Nov 15, 2023
Copy link
Contributor

@karl-cardenas-coding karl-cardenas-coding left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great, just some minor suggestions.

docs/docs-content/integrations/k3s.md Show resolved Hide resolved
docs/docs-content/integrations/k3s.md Outdated Show resolved Hide resolved
docs/docs-content/integrations/k3s.md Outdated Show resolved Hide resolved
docs/docs-content/integrations/k3s.md Outdated Show resolved Hide resolved
docs/docs-content/integrations/k3s.md Outdated Show resolved Hide resolved
Copy link
Contributor

@ritawatson ritawatson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just two comments that apply to all tabs. Great refactor.

Co-authored-by: Karl Cardenas <karl@spectrocloud.com>
Co-authored-by: Rita Watson <117382432+ritawatson@users.noreply.github.com>
@lennessyy lennessyy enabled auto-merge (squash) November 17, 2023 18:38
@lennessyy lennessyy merged commit 7fcadb1 into master Nov 17, 2023
8 checks passed
@lennessyy lennessyy deleted the k3s-pack-doc branch November 17, 2023 18:48
vault-token-factory-spectrocloud bot pushed a commit that referenced this pull request Nov 17, 2023
* started k3s pack document

* added parameter section

* add terraform section

* docs: add instructions on how to configure OIDC

* add OIDC configuration instructions

* add logo and spectro proxy reference

* tweak intro paragraph

* address vale comments

* added another parameter table for virtual clusters

* fix punctuation

* address some review comments and refactor

* Apply suggestions from code review

Co-authored-by: Rita Watson <117382432+ritawatson@users.noreply.github.com>
Co-authored-by: Karl Cardenas <karl@spectrocloud.com>

* Update docs/docs-content/integrations/k3s.md

Co-authored-by: Rita Watson <117382432+ritawatson@users.noreply.github.com>

* add Okta to accepted terms

* add clarification about palette as IDP

* clarify how to identify a user as a subject when creating role bindings with palette IDP

* modify configurations

* update terms

* add older versions

* Apply suggestions from code review

Co-authored-by: Karl Cardenas <karl@spectrocloud.com>
Co-authored-by: Rita Watson <117382432+ritawatson@users.noreply.github.com>

* add review comments to other versions

---------

Co-authored-by: Lenny Chen <lenny.chen@spectrocloud.com>
Co-authored-by: Rita Watson <117382432+ritawatson@users.noreply.github.com>
Co-authored-by: Karl Cardenas <karl@spectrocloud.com>
(cherry picked from commit 7fcadb1)
@vault-token-factory-spectrocloud
Copy link
Contributor

💔 Some backports could not be created

Status Branch Result
version-4-0 Backport failed because of merge conflicts
version-4-1

Note: Successful backport PRs will be merged automatically after passing CI.

Manual backport

To create the backport manually run:

backport --pr 1792

Questions ?

Please refer to the Backport tool documentation and see the Github Action logs for details

lennessyy added a commit that referenced this pull request Nov 17, 2023
* started k3s pack document

* added parameter section

* add terraform section

* docs: add instructions on how to configure OIDC

* add OIDC configuration instructions

* add logo and spectro proxy reference

* tweak intro paragraph

* address vale comments

* added another parameter table for virtual clusters

* fix punctuation

* address some review comments and refactor

* Apply suggestions from code review

Co-authored-by: Rita Watson <117382432+ritawatson@users.noreply.github.com>
Co-authored-by: Karl Cardenas <karl@spectrocloud.com>

* Update docs/docs-content/integrations/k3s.md

Co-authored-by: Rita Watson <117382432+ritawatson@users.noreply.github.com>

* add Okta to accepted terms

* add clarification about palette as IDP

* clarify how to identify a user as a subject when creating role bindings with palette IDP

* modify configurations

* update terms

* add older versions

* Apply suggestions from code review

Co-authored-by: Karl Cardenas <karl@spectrocloud.com>
Co-authored-by: Rita Watson <117382432+ritawatson@users.noreply.github.com>

* add review comments to other versions

---------

Co-authored-by: Lenny Chen <lenny.chen@spectrocloud.com>
Co-authored-by: Rita Watson <117382432+ritawatson@users.noreply.github.com>
Co-authored-by: Karl Cardenas <karl@spectrocloud.com>
(cherry picked from commit 7fcadb1)

Co-authored-by: Lenny Chen <55669665+lennessyy@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
auto-backport Enable backport backport-version-4-0 Backport change to version 4.0 backport-version-4-1 Backport change to version 4.1
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants