Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: add warning about silent build failures #1845

Merged
merged 4 commits into from
Nov 27, 2023
Merged

Conversation

lennessyy
Copy link
Contributor

Describe the Change

This PR adds a warning about silent build failures due to insufficient disk space and tells users how to comment out versions they do not want.

Review Changes

💻 Add Preview URL

🎫 Jira Ticket

Copy link

netlify bot commented Nov 27, 2023

Deploy Preview for docs-spectrocloud ready!

Name Link
🔨 Latest commit 792a156
🔍 Latest deploy log https://app.netlify.com/sites/docs-spectrocloud/deploys/65651fe7c7a92d00083f8dba
😎 Deploy Preview https://deploy-preview-1845--docs-spectrocloud.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@lennessyy lennessyy marked this pull request as ready for review November 27, 2023 19:04
@lennessyy lennessyy requested a review from a team as a code owner November 27, 2023 19:04
@lennessyy lennessyy added auto-backport Enable backport backport-version-4-1 Backport change to version 4.1 labels Nov 27, 2023
Co-authored-by: Karl Cardenas <karl@spectrocloud.com>
@lennessyy lennessyy enabled auto-merge (squash) November 27, 2023 23:02
@lennessyy lennessyy merged commit 090ef54 into master Nov 27, 2023
8 checks passed
@lennessyy lennessyy deleted the vmware-build-versions branch November 27, 2023 23:14
vault-token-factory-spectrocloud bot pushed a commit that referenced this pull request Nov 27, 2023
* docs: add warning about silent build failures

* docs: add wildcard to docker ls command

* docs: add example of commenting out a version

* Apply suggestions from code review

Co-authored-by: Karl Cardenas <karl@spectrocloud.com>

---------

Co-authored-by: Lenny Chen <lenny.chen@spectrocloud.com>
Co-authored-by: Karl Cardenas <karl@spectrocloud.com>
(cherry picked from commit 090ef54)
@vault-token-factory-spectrocloud
Copy link
Contributor

💚 All backports created successfully

Status Branch Result
version-4-1

Note: Successful backport PRs will be merged automatically after passing CI.

Questions ?

Please refer to the Backport tool documentation and see the Github Action logs for details

karl-cardenas-coding pushed a commit that referenced this pull request Nov 28, 2023
* docs: add warning about silent build failures

* docs: add wildcard to docker ls command

* docs: add example of commenting out a version

* Apply suggestions from code review

Co-authored-by: Karl Cardenas <karl@spectrocloud.com>

---------

Co-authored-by: Lenny Chen <lenny.chen@spectrocloud.com>
Co-authored-by: Karl Cardenas <karl@spectrocloud.com>
(cherry picked from commit 090ef54)

Co-authored-by: Lenny Chen <55669665+lennessyy@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
auto-backport Enable backport backport-version-4-1 Backport change to version 4.1
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants