Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Flannel Packs Page #1954

Merged
merged 6 commits into from
Jan 2, 2024
Merged

Flannel Packs Page #1954

merged 6 commits into from
Jan 2, 2024

Conversation

karl-cardenas-coding
Copy link
Contributor

@karl-cardenas-coding karl-cardenas-coding commented Jan 2, 2024

Describe the Change

This PR adds a pack's page for Flannel CNI.

Review Changes

💻 Preview URL

🎫 DOC-987

🎫 PAC-980

Copy link

netlify bot commented Jan 2, 2024

Deploy Preview for docs-spectrocloud ready!

Name Link
🔨 Latest commit 5fc5548
🔍 Latest deploy log https://app.netlify.com/sites/docs-spectrocloud/deploys/659474ed216fa90008b7b83b
😎 Deploy Preview https://deploy-preview-1954--docs-spectrocloud.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@karl-cardenas-coding karl-cardenas-coding added backport-version-4-0 Backport change to version 4.0 auto-backport Enable backport backport-version-3-4 Backport change to version 3.4 backport-version-4-1 Backport change to version 4.1 labels Jan 2, 2024
@karl-cardenas-coding karl-cardenas-coding marked this pull request as ready for review January 2, 2024 17:46
@karl-cardenas-coding karl-cardenas-coding requested a review from a team as a code owner January 2, 2024 17:46
docs/docs-content/integrations/flannel-cni.md Outdated Show resolved Hide resolved
docs/docs-content/integrations/flannel-cni.md Outdated Show resolved Hide resolved
docs/docs-content/integrations/flannel-cni.md Outdated Show resolved Hide resolved
docs/docs-content/integrations/flannel-cni.md Outdated Show resolved Hide resolved
docs/docs-content/integrations/flannel-cni.md Outdated Show resolved Hide resolved
docs/docs-content/integrations/flannel-cni.md Outdated Show resolved Hide resolved
docs/docs-content/integrations/flannel-cni.md Show resolved Hide resolved
docs/docs-content/integrations/flannel-cni.md Outdated Show resolved Hide resolved
docs/docs-content/integrations/flannel-cni.md Outdated Show resolved Hide resolved
docs/docs-content/integrations/flannel-cni.md Outdated Show resolved Hide resolved
Copy link
Contributor

@addetz addetz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a few minor comments. 🚀

docs/docs-content/integrations/flannel-cni.md Outdated Show resolved Hide resolved
docs/docs-content/integrations/flannel-cni.md Outdated Show resolved Hide resolved
docs/docs-content/integrations/flannel-cni.md Outdated Show resolved Hide resolved
docs/docs-content/integrations/flannel-cni.md Outdated Show resolved Hide resolved
docs/docs-content/integrations/flannel-cni.md Outdated Show resolved Hide resolved
```

</TabItem>
<TabItem label="Deprecated" value="deprecated">
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It seems like if we removed this tab and put the caution outside this section, we could remove a lot of the duplication of the Usage section which is repeated for each tab.

docs/docs-content/integrations/flannel-cni.md Outdated Show resolved Hide resolved
Co-authored-by: Adelina Simion <43963729+addetz@users.noreply.github.com>
@karl-cardenas-coding karl-cardenas-coding enabled auto-merge (squash) January 2, 2024 20:42
@karl-cardenas-coding karl-cardenas-coding merged commit fdeabbb into master Jan 2, 2024
8 checks passed
@karl-cardenas-coding karl-cardenas-coding deleted the flannel-cni-page branch January 2, 2024 20:53
vault-token-factory-spectrocloud bot pushed a commit that referenced this pull request Jan 2, 2024
* docs: flannel docs DOC-987

* docs: added more content PAC-980  DOC-987

* docs: vale feedback

* Apply suggestions from code review

Co-authored-by: Adelina Simion <43963729+addetz@users.noreply.github.com>

* docs: feedback

---------

Co-authored-by: Adelina Simion <43963729+addetz@users.noreply.github.com>
(cherry picked from commit fdeabbb)
vault-token-factory-spectrocloud bot pushed a commit that referenced this pull request Jan 2, 2024
* docs: flannel docs DOC-987

* docs: added more content PAC-980  DOC-987

* docs: vale feedback

* Apply suggestions from code review

Co-authored-by: Adelina Simion <43963729+addetz@users.noreply.github.com>

* docs: feedback

---------

Co-authored-by: Adelina Simion <43963729+addetz@users.noreply.github.com>
(cherry picked from commit fdeabbb)
vault-token-factory-spectrocloud bot pushed a commit that referenced this pull request Jan 2, 2024
* docs: flannel docs DOC-987

* docs: added more content PAC-980  DOC-987

* docs: vale feedback

* Apply suggestions from code review

Co-authored-by: Adelina Simion <43963729+addetz@users.noreply.github.com>

* docs: feedback

---------

Co-authored-by: Adelina Simion <43963729+addetz@users.noreply.github.com>
(cherry picked from commit fdeabbb)
@vault-token-factory-spectrocloud
Copy link
Contributor

💚 All backports created successfully

Status Branch Result
version-4-0
version-3-4
version-4-1

Note: Successful backport PRs will be merged automatically after passing CI.

Questions ?

Please refer to the Backport tool documentation and see the Github Action logs for details

karl-cardenas-coding added a commit that referenced this pull request Jan 2, 2024
* docs: flannel docs DOC-987

* docs: added more content PAC-980  DOC-987

* docs: vale feedback

* Apply suggestions from code review

Co-authored-by: Adelina Simion <43963729+addetz@users.noreply.github.com>

* docs: feedback

---------

Co-authored-by: Adelina Simion <43963729+addetz@users.noreply.github.com>
(cherry picked from commit fdeabbb)

Co-authored-by: Karl Cardenas <karl@spectrocloud.com>
karl-cardenas-coding added a commit that referenced this pull request Jan 2, 2024
* docs: flannel docs DOC-987

* docs: added more content PAC-980  DOC-987

* docs: vale feedback

* Apply suggestions from code review

Co-authored-by: Adelina Simion <43963729+addetz@users.noreply.github.com>

* docs: feedback

---------

Co-authored-by: Adelina Simion <43963729+addetz@users.noreply.github.com>
(cherry picked from commit fdeabbb)

Co-authored-by: Karl Cardenas <karl@spectrocloud.com>
karl-cardenas-coding added a commit that referenced this pull request Jan 2, 2024
* docs: flannel docs DOC-987

* docs: added more content PAC-980  DOC-987

* docs: vale feedback

* Apply suggestions from code review

Co-authored-by: Adelina Simion <43963729+addetz@users.noreply.github.com>

* docs: feedback

---------

Co-authored-by: Adelina Simion <43963729+addetz@users.noreply.github.com>
(cherry picked from commit fdeabbb)

Co-authored-by: Karl Cardenas <karl@spectrocloud.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
auto-backport Enable backport backport-version-3-4 Backport change to version 3.4 backport-version-4-0 Backport change to version 4.0 backport-version-4-1 Backport change to version 4.1
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants