Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Revert "chore: add acronym rule to vale DOC-940" #2278

Merged
merged 1 commit into from
Feb 23, 2024
Merged

Revert "chore: add acronym rule to vale DOC-940" #2278

merged 1 commit into from
Feb 23, 2024

Conversation

addetz
Copy link
Contributor

@addetz addetz commented Feb 23, 2024

Reverts #2273

@addetz addetz added backport-version-4-0 Backport change to version 4.0 auto-backport Enable backport backport-version-3-4 Backport change to version 3.4 backport-version-4-1 Backport change to version 4.1 backport-version-4-2 Backport change to version 4.2 labels Feb 23, 2024
@addetz addetz requested a review from a team as a code owner February 23, 2024 12:56
@netlify Netlify
Copy link

netlify bot commented Feb 23, 2024 •
edited
Loading

✅ Deploy Preview for docs-spectrocloud ready!

Name Link
🔨 Latest commit 60d4979
🔍 Latest deploy log https://app.netlify.com/sites/docs-spectrocloud/deploys/65d8960b99f850000896e06a
😎 Deploy Preview https://deploy-preview-2278--docs-spectrocloud.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

yuliiiah
yuliiiah approved these changes Feb 23, 2024
View reviewed changes
Copy link
Contributor

@yuliiiah yuliiiah left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Go forth! I believe in your ultimate victory!

@addetz addetz merged commit e1acc2d into master Feb 23, 2024
15 checks passed
@addetz addetz deleted the revert-2273-add-vale-capitalisation-doc-940 branch February 23, 2024 13:08
vault-token-factory-spectrocloud bot pushed a commit that referenced this pull request Feb 23, 2024
@addetz
Revert "chore: add acronym rule to vale DOC-940 (#2273)" (#2278)
6b414bf 
This reverts commit b5905d9.

(cherry picked from commit e1acc2d)
@vault-token-factory-spectrocloud vault-token-factory-spectrocloud bot mentioned this pull request Feb 23, 2024
Merged
vault-token-factory-spectrocloud bot pushed a commit that referenced this pull request Feb 23, 2024
@addetz
Revert "chore: add acronym rule to vale DOC-940 (#2273)" (#2278)
a4f511c 
This reverts commit b5905d9.

(cherry picked from commit e1acc2d)
@vault-token-factory-spectrocloud vault-token-factory-spectrocloud bot mentioned this pull request Feb 23, 2024
Merged
vault-token-factory-spectrocloud bot pushed a commit that referenced this pull request Feb 23, 2024
@addetz
Revert "chore: add acronym rule to vale DOC-940 (#2273)" (#2278)
828df78 
This reverts commit b5905d9.

(cherry picked from commit e1acc2d)
@vault-token-factory-spectrocloud vault-token-factory-spectrocloud bot mentioned this pull request Feb 23, 2024
Merged
vault-token-factory-spectrocloud bot pushed a commit that referenced this pull request Feb 23, 2024
@addetz
Revert "chore: add acronym rule to vale DOC-940 (#2273)" (#2278)
f2a3df8 
This reverts commit b5905d9.

(cherry picked from commit e1acc2d)
@vault-token-factory-spectrocloud vault-token-factory-spectrocloud bot mentioned this pull request Feb 23, 2024
Merged
@vault-token-factory-spectrocloud
Copy link
Contributor

💚 All backports created successfully

Status Branch Result
✅ version-4-0
✅ version-3-4
✅ version-4-1
✅ version-4-2

Note: Successful backport PRs will be merged automatically after passing CI.

Questions ?

Please refer to the Backport tool documentation and see the Github Action logs for details

vault-token-factory-spectrocloud bot added a commit that referenced this pull request Feb 23, 2024
@vault-token-factory-spectrocloud @addetz
Revert "chore: add acronym rule to vale DOC-940 (#2273)" (#2278) (#2280)
485e96a 
This reverts commit b5905d9.

(cherry picked from commit e1acc2d)

Co-authored-by: Adelina Simion <43963729+addetz@users.noreply.github.com>
vault-token-factory-spectrocloud bot added a commit that referenced this pull request Feb 23, 2024
@vault-token-factory-spectrocloud @addetz
Revert "chore: add acronym rule to vale DOC-940 (#2273)" (#2278) (#2281)
bde67f8 
This reverts commit b5905d9.

(cherry picked from commit e1acc2d)

Co-authored-by: Adelina Simion <43963729+addetz@users.noreply.github.com>
vault-token-factory-spectrocloud bot added a commit that referenced this pull request Feb 23, 2024
@vault-token-factory-spectrocloud @addetz
Revert "chore: add acronym rule to vale DOC-940 (#2273)" (#2278) (#2279)
8644d83 
This reverts commit b5905d9.

(cherry picked from commit e1acc2d)

Co-authored-by: Adelina Simion <43963729+addetz@users.noreply.github.com>
vault-token-factory-spectrocloud bot added a commit that referenced this pull request Feb 23, 2024
@vault-token-factory-spectrocloud @addetz
Revert "chore: add acronym rule to vale DOC-940 (#2273)" (#2278) (#2282)
7792c2d 
This reverts commit b5905d9.

(cherry picked from commit e1acc2d)

Co-authored-by: Adelina Simion <43963729+addetz@users.noreply.github.com>
@vault-token-factory-spectrocloud
Copy link
Contributor

🎉 This PR is included in version 4.2.1 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

@vault-token-factory-spectrocloud
Copy link
Contributor

🎉 This PR is included in version 4.2.1 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yuliiiah yuliiiah yuliiiah approved these changes

@karl-cardenas-coding karl-cardenas-coding Awaiting requested review from karl-cardenas-coding karl-cardenas-coding is a code owner automatically assigned from spectrocloud/docs-education

@lennessyy lennessyy Awaiting requested review from lennessyy lennessyy is a code owner automatically assigned from spectrocloud/docs-education

Assignees
No one assigned
Labels
auto-backport Enable backport backport-version-3-4 Backport change to version 3.4 backport-version-4-0 Backport change to version 4.0 backport-version-4-1 Backport change to version 4.1 backport-version-4-2 Backport change to version 4.2 released
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@addetz @yuliiiah