Visual tests #2534
Merged
Visual tests #2534
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
🤖 Starting the visual tests. This will take approximately an hour. |
|
Visual Tests canceled for this last commit |
addetz
approved these changes
Apr 2, 2024
| defaults: | ||
| run: | ||
| shell: bash | ||
| if: ${{ !github.event.pull_request.draft && github.actor != 'dependabot[bot]' && github.actor != 'dependabot-preview[bot]' || contains(github.event.pull_request.labels.*.name, 'visual-tests') }} |
There was a problem hiding this comment.
Out of scope on this one, but if the main PR is marked with visual-tests surely the backports should be too? I wonder if we should change the backport logic to apply this label to backports too.
| path: build | ||
| attempt_delay: 60000 # 1 minute | ||
|
|
||
| - name: Download Reference Screenshots |
There was a problem hiding this comment.
Can we add some kind of warning if the reference shots are not found in the case they've expired? Would stop a mini heart-attack if everything fails lol
| defaults: | ||
| run: | ||
| shell: bash | ||
| if: ${{ !github.event.pull_request.draft && github.actor != 'dependabot[bot]' && github.actor != 'dependabot-preview[bot]' || contains(github.event.pull_request.labels.*.name, 'visual-tests') }} |
There was a problem hiding this comment.
Perhaps I missed this but where do you detect if changes are made to the src/** or package.json files? This was mentioned in the confluence page
karl-cardenas-coding
added
backport-version-4-0
vault-token-factory-spectrocloud bot
pushed a commit
that referenced
this pull request
Apr 2, 2024
* ci: testing visual comp * ci: more test * test: changes * chore: update CI * chore: fix npm * save * chore: working locally * chore: working logic * chore: save * chore: testing CI * ci: test ci * ci: more test * ci: more ci tests * ci: test * chore: updated test * chore: test * more tests * ci: test * ci: change folder structure * chore: fixed ci * chore: reduce test feedback * chore: more test * ci: path change * ci: more test * ci: update tar config * ci: retrest * chore: test * chore: test * ci: more test * chore: more test * save * ci: different workflow * chore: fixed logic * chore: more tests * core: ready for PR test * ci: added missing steps * ci: screenshot logic * ci: trigger * ci: more logic * ci: fix test path * test: new logic * ci: fix download path * chore: ready * save * ci: more tests * ci: fix screenshots * ci: more changes * chore: more tests * ci: more tests * chore: restart * chore: update * ci: removed Appzi from builds * chore: save * ci: new test * save * ci: updated artifacts logic * chore: verify self-hosted runner * chore: ready for merge (cherry picked from commit 0670689)
vault-token-factory-spectrocloud bot
pushed a commit
that referenced
this pull request
Apr 2, 2024
* ci: testing visual comp * ci: more test * test: changes * chore: update CI * chore: fix npm * save * chore: working locally * chore: working logic * chore: save * chore: testing CI * ci: test ci * ci: more test * ci: more ci tests * ci: test * chore: updated test * chore: test * more tests * ci: test * ci: change folder structure * chore: fixed ci * chore: reduce test feedback * chore: more test * ci: path change * ci: more test * ci: update tar config * ci: retrest * chore: test * chore: test * ci: more test * chore: more test * save * ci: different workflow * chore: fixed logic * chore: more tests * core: ready for PR test * ci: added missing steps * ci: screenshot logic * ci: trigger * ci: more logic * ci: fix test path * test: new logic * ci: fix download path * chore: ready * save * ci: more tests * ci: fix screenshots * ci: more changes * chore: more tests * ci: more tests * chore: restart * chore: update * ci: removed Appzi from builds * chore: save * ci: new test * save * ci: updated artifacts logic * chore: verify self-hosted runner * chore: ready for merge (cherry picked from commit 0670689)
vault-token-factory-spectrocloud bot
pushed a commit
that referenced
this pull request
Apr 2, 2024
* ci: testing visual comp * ci: more test * test: changes * chore: update CI * chore: fix npm * save * chore: working locally * chore: working logic * chore: save * chore: testing CI * ci: test ci * ci: more test * ci: more ci tests * ci: test * chore: updated test * chore: test * more tests * ci: test * ci: change folder structure * chore: fixed ci * chore: reduce test feedback * chore: more test * ci: path change * ci: more test * ci: update tar config * ci: retrest * chore: test * chore: test * ci: more test * chore: more test * save * ci: different workflow * chore: fixed logic * chore: more tests * core: ready for PR test * ci: added missing steps * ci: screenshot logic * ci: trigger * ci: more logic * ci: fix test path * test: new logic * ci: fix download path * chore: ready * save * ci: more tests * ci: fix screenshots * ci: more changes * chore: more tests * ci: more tests * chore: restart * chore: update * ci: removed Appzi from builds * chore: save * ci: new test * save * ci: updated artifacts logic * chore: verify self-hosted runner * chore: ready for merge (cherry picked from commit 0670689)
💔 Some backports could not be created
Note: Successful backport PRs will be merged automatically after passing CI. Manual backportTo create the backport manually run: Questions ?Please refer to the Backport tool documentation and see the Github Action logs for details |
vault-token-factory-spectrocloud bot
added a commit
that referenced
this pull request
Apr 2, 2024
* ci: testing visual comp * ci: more test * test: changes * chore: update CI * chore: fix npm * save * chore: working locally * chore: working logic * chore: save * chore: testing CI * ci: test ci * ci: more test * ci: more ci tests * ci: test * chore: updated test * chore: test * more tests * ci: test * ci: change folder structure * chore: fixed ci * chore: reduce test feedback * chore: more test * ci: path change * ci: more test * ci: update tar config * ci: retrest * chore: test * chore: test * ci: more test * chore: more test * save * ci: different workflow * chore: fixed logic * chore: more tests * core: ready for PR test * ci: added missing steps * ci: screenshot logic * ci: trigger * ci: more logic * ci: fix test path * test: new logic * ci: fix download path * chore: ready * save * ci: more tests * ci: fix screenshots * ci: more changes * chore: more tests * ci: more tests * chore: restart * chore: update * ci: removed Appzi from builds * chore: save * ci: new test * save * ci: updated artifacts logic * chore: verify self-hosted runner * chore: ready for merge (cherry picked from commit 0670689) Co-authored-by: Karl Cardenas <karl@spectrocloud.com>
vault-token-factory-spectrocloud bot
added a commit
that referenced
this pull request
Apr 2, 2024
* ci: testing visual comp * ci: more test * test: changes * chore: update CI * chore: fix npm * save * chore: working locally * chore: working logic * chore: save * chore: testing CI * ci: test ci * ci: more test * ci: more ci tests * ci: test * chore: updated test * chore: test * more tests * ci: test * ci: change folder structure * chore: fixed ci * chore: reduce test feedback * chore: more test * ci: path change * ci: more test * ci: update tar config * ci: retrest * chore: test * chore: test * ci: more test * chore: more test * save * ci: different workflow * chore: fixed logic * chore: more tests * core: ready for PR test * ci: added missing steps * ci: screenshot logic * ci: trigger * ci: more logic * ci: fix test path * test: new logic * ci: fix download path * chore: ready * save * ci: more tests * ci: fix screenshots * ci: more changes * chore: more tests * ci: more tests * chore: restart * chore: update * ci: removed Appzi from builds * chore: save * ci: new test * save * ci: updated artifacts logic * chore: verify self-hosted runner * chore: ready for merge (cherry picked from commit 0670689) Co-authored-by: Karl Cardenas <karl@spectrocloud.com>
vault-token-factory-spectrocloud bot
added a commit
that referenced
this pull request
Apr 2, 2024
* ci: testing visual comp * ci: more test * test: changes * chore: update CI * chore: fix npm * save * chore: working locally * chore: working logic * chore: save * chore: testing CI * ci: test ci * ci: more test * ci: more ci tests * ci: test * chore: updated test * chore: test * more tests * ci: test * ci: change folder structure * chore: fixed ci * chore: reduce test feedback * chore: more test * ci: path change * ci: more test * ci: update tar config * ci: retrest * chore: test * chore: test * ci: more test * chore: more test * save * ci: different workflow * chore: fixed logic * chore: more tests * core: ready for PR test * ci: added missing steps * ci: screenshot logic * ci: trigger * ci: more logic * ci: fix test path * test: new logic * ci: fix download path * chore: ready * save * ci: more tests * ci: fix screenshots * ci: more changes * chore: more tests * ci: more tests * chore: restart * chore: update * ci: removed Appzi from builds * chore: save * ci: new test * save * ci: updated artifacts logic * chore: verify self-hosted runner * chore: ready for merge (cherry picked from commit 0670689) Co-authored-by: Karl Cardenas <karl@spectrocloud.com>
|
🎉 This PR is included in version 4.2.1 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
|
🎉 This PR is included in version 4.2.1 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
Merged
2 tasks
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe the Change
This PR introduces visual regression testing capabilities to the documentation site.
Changed Pages
💻 Preview URL for Page
Jira Tickets
🎫 Jira Ticket
Backports
Can this PR be backported?