Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: add missing fips cmd to user data #2886

Merged
merged 9 commits into from
May 23, 2024
Merged

docs: add missing fips cmd to user data #2886

merged 9 commits into from
May 23, 2024

Conversation

lennessyy
Copy link
Contributor

@lennessyy lennessyy commented May 22, 2024

Describe the Change

This PR adds an additional user data configuration to apply with the new version of Kairos for FIPS build.

Changed Pages

💻 FIPS

Jira Tickets

🎫 DOC-1196

Backports

Can this PR be backported?

  • Yes. Remember to add the relevant backport labels to your PR.

@lennessyy lennessyy added auto-backport Enable backport backport-version-4-3 Backport change to version 4.3 labels May 22, 2024
Copy link

netlify bot commented May 22, 2024

Deploy Preview for docs-spectrocloud ready!

Name Link
🔨 Latest commit d18ed0e
🔍 Latest deploy log https://app.netlify.com/sites/docs-spectrocloud/deploys/664fa877b059610008e837af
😎 Deploy Preview https://deploy-preview-2886--docs-spectrocloud.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@lennessyy lennessyy marked this pull request as ready for review May 22, 2024 00:29
@lennessyy lennessyy requested a review from a team as a code owner May 22, 2024 00:29
@MooseOnTehLoose
Copy link

Looks great! Tony approved.

@hausmckinney
Copy link
Contributor

Nice work

of your VerteX instance.
14. Create a file named **user-data**. It must have the `#cloud-init` header at the top of the file. Ensure you have the
following blocks at the root level of the **user-data** file. Replace the value for `edgeHostToken` with your VerteX
registration token, and replace the value `paletteEndPoint` with the URL of your VerteX instance. Replace the user
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's link to the registration token page (how-to)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We did link to the page at the prerequisite section already. Maybe we don't need to add a second link?

Copy link
Contributor

@karl-cardenas-coding karl-cardenas-coding left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just some minor suggestions

@lennessyy lennessyy enabled auto-merge (squash) May 23, 2024 20:35
@lennessyy lennessyy merged commit 001a56c into master May 23, 2024
14 of 15 checks passed
@lennessyy lennessyy deleted the fips-fix branch May 23, 2024 20:45
vault-token-factory-spectrocloud bot pushed a commit that referenced this pull request May 23, 2024
* docs: change fips build branch

* docs: remove main

* docs: add additional user data info

* docs: add further fixes

* copyedits

* Apply suggestions from code review

Co-authored-by: Karl Cardenas <karl@spectrocloud.com>

* docs: add project name

---------

Co-authored-by: Lenny Chen <lenny.chen@spectrocloud.com>
Co-authored-by: Karl Cardenas <karl@spectrocloud.com>
(cherry picked from commit 001a56c)
@vault-token-factory-spectrocloud
Copy link
Contributor

💚 All backports created successfully

Status Branch Result
version-4-3

Note: Successful backport PRs will be merged automatically after passing CI.

Questions ?

Please refer to the Backport tool documentation and see the Github Action logs for details

vault-token-factory-spectrocloud bot added a commit that referenced this pull request May 23, 2024
* docs: change fips build branch

* docs: remove main

* docs: add additional user data info

* docs: add further fixes

* copyedits

* Apply suggestions from code review

Co-authored-by: Karl Cardenas <karl@spectrocloud.com>

* docs: add project name

---------

Co-authored-by: Lenny Chen <lenny.chen@spectrocloud.com>
Co-authored-by: Karl Cardenas <karl@spectrocloud.com>
(cherry picked from commit 001a56c)

Co-authored-by: Lenny Chen <55669665+lennessyy@users.noreply.github.com>
@vault-token-factory-spectrocloud
Copy link
Contributor

🎉 This PR is included in version 4.4.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
auto-backport Enable backport backport-version-4-3 Backport change to version 4.3 released
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants