Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix the markup and layout of pages in the VMO section #2928

Merged
merged 8 commits into from
May 28, 2024
Merged

Fix the markup and layout of pages in the VMO section #2928

merged 8 commits into from
May 28, 2024

Conversation

yuliiiah
Copy link
Contributor

@yuliiiah yuliiiah commented May 28, 2024 •
edited
Loading

Describe the Change

This PR addresses some markup and layout issues in the VMO section.

Changed Pages

💻 Virtual Machine Orchestrator

Backports

Can this PR be backported?

  • Yes. Remember to add the relevant backport labels to your PR.
  • No. Please leave a short comment below about why this PR cannot be backported.

@yuliiiah yuliiiah added backport-version-4-0 Backport change to version 4.0 auto-backport Enable backport backport-version-3-4 Backport change to version 3.4 backport-version-4-1 Backport change to version 4.1 backport-version-4-2 Backport change to version 4.2 backport-version-4-3 Backport change to version 4.3 labels May 28, 2024
@yuliiiah yuliiiah requested a review from a team as a code owner May 28, 2024 13:28
@netlify Netlify
Copy link

netlify bot commented May 28, 2024 •
edited
Loading

✅ Deploy Preview for docs-spectrocloud ready!

Name Link
🔨 Latest commit 93a5f9c
🔍 Latest deploy log https://app.netlify.com/sites/docs-spectrocloud/deploys/66561cf7c8234f0008b3159d
😎 Deploy Preview https://deploy-preview-2928--docs-spectrocloud.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

caroldelwing
caroldelwing approved these changes May 28, 2024
View reviewed changes
Copy link
Contributor

@caroldelwing caroldelwing left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good :)

@karl-cardenas-coding
Copy link
Contributor

@yuliiiah

I ran link checker and it looks like kubevirt rolled out some doc changes over the weekend.
"https://kubevirt.io/user-guide/operations/activating_feature_gates/",404,BROKEN,"docs/docs-content/vm-management/vm-management.md",""
"https://kubevirt.io/user-guide/operations/installation/",404,BROKEN,"docs/docs-content/integrations/kubevirt.md",""
"https://kubevirt.io/user-guide/virtual_machines/dedicated_cpu_resources/",404,BROKEN,"docs/docs-content/vm-management/create-manage-vm/vm-oversubscription.md",""
"https://kubevirt.io/user-guide/operations/node_overcommit/",404,BROKEN,"docs/docs-content/vm-management/create-manage-vm/vm-oversubscription.md",""
"https://kubevirt.io/user-guide/virtual_machines/virtual_hardware/",404,BROKEN,"docs/docs-content/vm-management/create-manage-vm/vm-oversubscription.md",""
"https://kubevirt.io/user-guide/operations/virtctl_client_tool/",404,BROKEN,"docs/docs-content/clusters/cluster-management/palette-webctl.md",""

@yuliiiah
Copy link
Contributor Author

Oh wow Karl, thanks for catching these!

@yuliiiah yuliiiah merged commit 05913e3 into master May 28, 2024
15 checks passed
@yuliiiah yuliiiah deleted the vmo-markup-layout branch May 28, 2024 18:18
vault-token-factory-spectrocloud bot pushed a commit that referenced this pull request May 28, 2024
@yuliiiah
Fix the markup and layout of pages in the VMO section (#2928)
3b24dcb 
* chore: Fix markup in the VMO docs

* chore: Improve page layout in the VMO section

* chore: Fix another small isue in the layout

* chore: Fix broken links in the VMO section

* chore: Fix a missed broken link

* docs: Remove the mention of virtual clusters from VMO

(cherry picked from commit 05913e3)
@vault-token-factory-spectrocloud vault-token-factory-spectrocloud bot mentioned this pull request May 28, 2024
Merged
@vault-token-factory-spectrocloud
Copy link
Contributor

💔 Some backports could not be created

Status Branch Result
❌ version-4-0 Backport failed because of merge conflicts

You might need to backport the following PRs to version-4-0:
- chore: bump sigstore/cosign-installer from 3.4.0 to 3.5.0 (#2730)
❌ version-3-4 Backport failed because of merge conflicts

You might need to backport the following PRs to version-3-4:
- docs: fixed broken URLs (#2749)
❌ version-4-1 Backport failed because of merge conflicts

You might need to backport the following PRs to version-4-1:
- chore: bump sigstore/cosign-installer from 3.4.0 to 3.5.0 (#2730)
❌ version-4-2 Backport failed because of merge conflicts

You might need to backport the following PRs to version-4-2:
- replace caution with warning (#2039)
✅ version-4-3

Note: Successful backport PRs will be merged automatically after passing CI.

Manual backport

To create the backport manually run:

backport --pr 2928

Questions ?

Please refer to the Backport tool documentation and see the Github Action logs for details

yuliiiah added a commit that referenced this pull request May 28, 2024
@yuliiiah
Fix the markup and layout of pages in the VMO section (#2928)
eb667a5 
* chore: Fix markup in the VMO docs

* chore: Improve page layout in the VMO section

* chore: Fix another small isue in the layout

* chore: Fix broken links in the VMO section

* chore: Fix a missed broken link

* docs: Remove the mention of virtual clusters from VMO
vault-token-factory-spectrocloud bot added a commit that referenced this pull request May 28, 2024
@vault-token-factory-spectrocloud @yuliiiah
Fix the markup and layout of pages in the VMO section (#2928) (#2931)
614ab18 
* chore: Fix markup in the VMO docs

* chore: Improve page layout in the VMO section

* chore: Fix another small isue in the layout

* chore: Fix broken links in the VMO section

* chore: Fix a missed broken link

* docs: Remove the mention of virtual clusters from VMO

(cherry picked from commit 05913e3)

Co-authored-by: Yuliia Horbenko <31223054+yuliiiah@users.noreply.github.com>
yuliiiah added a commit that referenced this pull request May 28, 2024
@yuliiiah
Fix the markup and layout of pages in the VMO section (#2928)
f3de88c 
* chore: Fix markup in the VMO docs

* chore: Improve page layout in the VMO section

* chore: Fix another small isue in the layout

* chore: Fix broken links in the VMO section

* chore: Fix a missed broken link

* docs: Remove the mention of virtual clusters from VMO
yuliiiah added a commit that referenced this pull request May 28, 2024
@yuliiiah
Fix the markup and layout of pages in the VMO section (#2928)
204c8e0 
* chore: Fix markup in the VMO docs

* chore: Improve page layout in the VMO section

* chore: Fix another small isue in the layout

* chore: Fix broken links in the VMO section

* chore: Fix a missed broken link

* docs: Remove the mention of virtual clusters from VMO
This was referenced May 28, 2024
Merged
Merged
Merged
yuliiiah added a commit that referenced this pull request May 28, 2024
@yuliiiah
Fix the markup and layout of pages in the VMO section (#2928)
f6582f9 
* chore: Fix markup in the VMO docs

* chore: Improve page layout in the VMO section

* chore: Fix another small isue in the layout

* chore: Fix broken links in the VMO section

* chore: Fix a missed broken link

* docs: Remove the mention of virtual clusters from VMO
@yuliiiah yuliiiah mentioned this pull request May 28, 2024
Merged
yuliiiah added a commit that referenced this pull request May 28, 2024
@yuliiiah
Fix the markup and layout of pages in the VMO section (#2928) (#2934)
0316689 
* chore: Fix markup in the VMO docs

* chore: Improve page layout in the VMO section

* chore: Fix another small isue in the layout

* chore: Fix broken links in the VMO section

* chore: Fix a missed broken link

* docs: Remove the mention of virtual clusters from VMO
yuliiiah added a commit that referenced this pull request May 28, 2024
@yuliiiah
Fix the markup and layout of pages in the VMO section (#2928) (#2935)
2526500 
* chore: Fix markup in the VMO docs

* chore: Improve page layout in the VMO section

* chore: Fix another small isue in the layout

* chore: Fix broken links in the VMO section

* chore: Fix a missed broken link

* docs: Remove the mention of virtual clusters from VMO
yuliiiah added a commit that referenced this pull request May 28, 2024
@yuliiiah
Fix the markup and layout of pages in the VMO section (#2928) (#2933)
3786a03 
* chore: Fix markup in the VMO docs

* chore: Improve page layout in the VMO section

* chore: Fix another small isue in the layout

* chore: Fix broken links in the VMO section

* chore: Fix a missed broken link

* docs: Remove the mention of virtual clusters from VMO
yuliiiah added a commit that referenced this pull request May 28, 2024
@yuliiiah
Fix the markup and layout of pages in the VMO section (#2928) (#2932)
798a22e 
* chore: Fix markup in the VMO docs

* chore: Improve page layout in the VMO section

* chore: Fix another small isue in the layout

* chore: Fix broken links in the VMO section

* chore: Fix a missed broken link

* docs: Remove the mention of virtual clusters from VMO
@vault-token-factory-spectrocloud
Copy link
Contributor

🎉 This PR is included in version 4.4.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@github-actions GitHub Actions github-actions left review comments

@caroldelwing caroldelwing caroldelwing approved these changes

@karl-cardenas-coding karl-cardenas-coding Awaiting requested review from karl-cardenas-coding karl-cardenas-coding is a code owner automatically assigned from spectrocloud/docs-education

@addetz addetz Awaiting requested review from addetz addetz is a code owner automatically assigned from spectrocloud/docs-education

Assignees
No one assigned
Labels
auto-backport Enable backport backport-version-3-4 Backport change to version 3.4 backport-version-4-0 Backport change to version 4.0 backport-version-4-1 Backport change to version 4.1 backport-version-4-2 Backport change to version 4.2 backport-version-4-3 Backport change to version 4.3 released
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@yuliiiah @karl-cardenas-coding @caroldelwing