Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Self-Hosted Custom CA Update #3061

Merged
merged 7 commits into from
Jun 20, 2024
Merged

Self-Hosted Custom CA Update #3061

merged 7 commits into from
Jun 20, 2024

Conversation

karl-cardenas-coding
Copy link
Contributor

@karl-cardenas-coding karl-cardenas-coding commented Jun 11, 2024

Describe the Change

This PR updates the instructions for installing a custom CA when deploying Palette or VerteX in an airgap environment.

Changed Pages

💻 Preview URL for Page

Jira Tickets

🎫 DOC-1224

Backports

Can this PR be backported?

  • Yes. Remember to add the relevant backport labels to your PR.
  • No. Please leave a short comment below about why this PR cannot be backported.

Copy link

netlify bot commented Jun 11, 2024

Deploy Preview for docs-spectrocloud ready!

Name Link
🔨 Latest commit fc9c8bf
🔍 Latest deploy log https://app.netlify.com/sites/docs-spectrocloud/deploys/66749dcc73fd3c00087a14f4
😎 Deploy Preview https://deploy-preview-3061--docs-spectrocloud.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@karl-cardenas-coding karl-cardenas-coding marked this pull request as ready for review June 11, 2024 23:08
@karl-cardenas-coding karl-cardenas-coding requested a review from a team as a code owner June 11, 2024 23:08
- The custom certificate's Fully Qualified Domain Name (FQDN) must match the hostname or IP address you provide for
the airgap support VM. Otherwise, the airgap setup process will fail due to a certificate mismatch.

- The custom SSL certificates must have the following permissions bits set:
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚫 [vale] reported by reviewdog 🐶
[spectrocloud.colon] Use colons only to introduce lists, unless in code blocks or inline code.

- **server.crt**: 644
- **server.key**: 600

:::
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚫 [vale] reported by reviewdog 🐶
[spectrocloud.colon] Use colons only to introduce lists, unless in code blocks or inline code.

Copy link
Contributor

@caroldelwing caroldelwing left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved with a tiny question :)
I could not leave a comment there, but there is a box in step 17 of the VerteX page that is not aligned.


- **server.crt**
- **server.key**
Repository, copy the custom SSL certificates, in base64 PEM format, to the airgap support VM.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
Repository, copy the custom SSL certificates, in base64 PEM format, to the airgap support VM.
Repository, copy the custom SSL certificates in base64 PEM format to the airgap support VM.

maybe? :)


- **server.crt**
- **server.key**
Repository, copy the custom SSL certificates, in base64 PEM format, to the airgap support VM.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
Repository, copy the custom SSL certificates, in base64 PEM format, to the airgap support VM.
Repository, copy the custom SSL certificates in base64 PEM format to the airgap support VM.

maybe? :)


- The custom SSL certificates must be in base64 PEM format. If you have custom SSL certificates in a different
format, convert them to base64 PEM format before copying them to the support VM. The airgap setup process also
expects the files to be named **server.crt** and **server.key**.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same question hehe Which files?

@karl-cardenas-coding karl-cardenas-coding enabled auto-merge (squash) June 20, 2024 21:25
@karl-cardenas-coding karl-cardenas-coding added backport-version-4-0 Backport change to version 4.0 auto-backport Enable backport backport-version-4-1 Backport change to version 4.1 backport-version-4-2 Backport change to version 4.2 backport-version-4-3 Backport change to version 4.3 backport-version-4-4 Backport change to version 4.4 labels Jun 20, 2024
@karl-cardenas-coding karl-cardenas-coding merged commit f775c3c into master Jun 20, 2024
26 checks passed
@karl-cardenas-coding karl-cardenas-coding deleted the airgap-scar-steps branch June 20, 2024 21:34
vault-token-factory-spectrocloud bot pushed a commit that referenced this pull request Jun 20, 2024
* docs: DOC-1224

* docs: vertex steps

* docs: updated instructions

* Apply suggestions from code review

(cherry picked from commit f775c3c)
vault-token-factory-spectrocloud bot pushed a commit that referenced this pull request Jun 20, 2024
* docs: DOC-1224

* docs: vertex steps

* docs: updated instructions

* Apply suggestions from code review

(cherry picked from commit f775c3c)
@vault-token-factory-spectrocloud
Copy link
Contributor

💔 Some backports could not be created

Status Branch Result
version-4-0 Backport failed because of merge conflicts
version-4-1 Backport failed because of merge conflicts
version-4-2 Backport failed because of merge conflicts
version-4-3
version-4-4

Note: Successful backport PRs will be merged automatically after passing CI.

Manual backport

To create the backport manually run:

backport --pr 3061

Questions ?

Please refer to the Backport tool documentation and see the Github Action logs for details

karl-cardenas-coding added a commit that referenced this pull request Jun 20, 2024
* docs: DOC-1224

* docs: vertex steps

* docs: updated instructions

* Apply suggestions from code review
vault-token-factory-spectrocloud bot added a commit that referenced this pull request Jun 20, 2024
* docs: DOC-1224

* docs: vertex steps

* docs: updated instructions

* Apply suggestions from code review

(cherry picked from commit f775c3c)

Co-authored-by: Karl Cardenas <29551334+karl-cardenas-coding@users.noreply.github.com>
vault-token-factory-spectrocloud bot added a commit that referenced this pull request Jun 20, 2024
* docs: DOC-1224

* docs: vertex steps

* docs: updated instructions

* Apply suggestions from code review

(cherry picked from commit f775c3c)

Co-authored-by: Karl Cardenas <29551334+karl-cardenas-coding@users.noreply.github.com>
karl-cardenas-coding added a commit that referenced this pull request Jun 20, 2024
* docs: DOC-1224

* docs: vertex steps

* docs: updated instructions

* Apply suggestions from code review
karl-cardenas-coding added a commit that referenced this pull request Jun 20, 2024
* docs: DOC-1224

* docs: vertex steps

* docs: updated instructions

* Apply suggestions from code review
karl-cardenas-coding added a commit that referenced this pull request Jun 20, 2024
)

* docs: DOC-1224 Self-Hosted Custom CA Update (#3061)

* docs: DOC-1224

* docs: vertex steps

* docs: updated instructions

* Apply suggestions from code review

* chore: fix indent
karl-cardenas-coding added a commit that referenced this pull request Jun 20, 2024
* docs: DOC-1224

* docs: vertex steps

* docs: updated instructions

* Apply suggestions from code review
karl-cardenas-coding added a commit that referenced this pull request Jun 20, 2024
* docs: DOC-1224

* docs: vertex steps

* docs: updated instructions

* Apply suggestions from code review
@JPedro2
Copy link
Contributor

JPedro2 commented Jun 21, 2024

@karl-cardenas-coding the below is actually not needed anymore. It was needed in 4.2.13 but in 4.3.6 the airgap.sh script does it already by default as it copies the certs from /opt/spectro/ssl

Screenshot 2024-06-21 at 18 29 58

nage1234 pushed a commit that referenced this pull request Jun 28, 2024
* docs: DOC-1224

* docs: vertex steps

* docs: updated instructions

* Apply suggestions from code review
nage1234 added a commit that referenced this pull request Jun 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
auto-backport Enable backport backport-version-4-0 Backport change to version 4.0 backport-version-4-1 Backport change to version 4.1 backport-version-4-2 Backport change to version 4.2 backport-version-4-3 Backport change to version 4.3 backport-version-4-4 Backport change to version 4.4
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants