Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: add additional qualifier for network environments #3344

Merged
merged 3 commits into from
Jul 12, 2024
Merged

Conversation

lennessyy
Copy link
Contributor

@lennessyy lennessyy commented Jul 11, 2024

Describe the Change

This PR clarifies that DHCP is not supported when Edge hosts have more than one NIC.

Changed Pages

💻 Add Preview URL for Page

Jira Tickets

🎫 PE-4680

Backports

Can this PR be backported?

  • Yes. Remember to add the relevant backport labels to your PR.
  • No. Please leave a short comment below about why this PR cannot be backported.

Copy link

netlify bot commented Jul 11, 2024

Deploy Preview for docs-spectrocloud ready!

Name Link
🔨 Latest commit e997e36
🔍 Latest deploy log https://app.netlify.com/sites/docs-spectrocloud/deploys/6691516345320c0008db74f5
😎 Deploy Preview https://deploy-preview-3344--docs-spectrocloud.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@lennessyy lennessyy added auto-backport Enable backport backport-version-4-2 Backport change to version 4.2 backport-version-4-3 Backport change to version 4.3 backport-version-4-4 Backport change to version 4.4 labels Jul 11, 2024
@lennessyy lennessyy marked this pull request as ready for review July 11, 2024 22:03
@lennessyy lennessyy requested a review from a team as a code owner July 11, 2024 22:03
- Use static IP addresses. Contact your network administrator to assign the Edge host a static IP address.
- Use Dynamic Host Configuration Protocol (DHCP) reservations to reserve an IP address in a DHCP network. Contact your
network administrator to reserve IP addresses for your Edge hosts in a DHCP network.
- Enable network overlay on your Edge cluster. Network overlay can only be enabled during cluster creation. For more
information about network overlay, refer to [Enable Overlay Network](../networking/vxlan-overlay.md).

:::warning

If any of your your Edge hosts has more than one Network Interface Card (NIC), you must either use static IP
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚫 [vale] reported by reviewdog 🐶
[Vale.Repetition] 'your' is repeated!

- Use static IP addresses. Contact your network administrator to assign the Edge host a static IP address.
- Use Dynamic Host Configuration Protocol (DHCP) reservations to reserve an IP address in a DHCP network. Contact your
network administrator to reserve IP addresses for your Edge hosts in a DHCP network.
- Enable network overlay on your Edge cluster. Network overlay can only be enabled during cluster creation. For more
information about network overlay, refer to [Enable Overlay Network](../networking/vxlan-overlay.md).

:::warning

If any of your your Edge hosts has more than one Network Interface Card (NIC), you must either use static IP
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
If any of your your Edge hosts has more than one Network Interface Card (NIC), you must either use static IP
If any of your Edge hosts have more than one Network Interface Card (NIC), you must either use static IP

Minor cleanup

@lennessyy lennessyy enabled auto-merge (squash) July 12, 2024 15:53
@lennessyy lennessyy merged commit c84211b into master Jul 12, 2024
15 checks passed
@lennessyy lennessyy deleted the PE-4630 branch July 12, 2024 16:03
vault-token-factory-spectrocloud bot pushed a commit that referenced this pull request Jul 12, 2024
* docs: add additional qualifier

* docs: grammar

---------

Co-authored-by: Lenny Chen <lenny.chen@spectrocloud.com>
(cherry picked from commit c84211b)
vault-token-factory-spectrocloud bot pushed a commit that referenced this pull request Jul 12, 2024
* docs: add additional qualifier

* docs: grammar

---------

Co-authored-by: Lenny Chen <lenny.chen@spectrocloud.com>
(cherry picked from commit c84211b)
vault-token-factory-spectrocloud bot pushed a commit that referenced this pull request Jul 12, 2024
* docs: add additional qualifier

* docs: grammar

---------

Co-authored-by: Lenny Chen <lenny.chen@spectrocloud.com>
(cherry picked from commit c84211b)
@vault-token-factory-spectrocloud
Copy link
Contributor

💚 All backports created successfully

Status Branch Result
version-4-2
version-4-3
version-4-4

Note: Successful backport PRs will be merged automatically after passing CI.

Questions ?

Please refer to the Backport tool documentation and see the Github Action logs for details

vault-token-factory-spectrocloud bot added a commit that referenced this pull request Jul 12, 2024
* docs: add additional qualifier

* docs: grammar

---------

Co-authored-by: Lenny Chen <lenny.chen@spectrocloud.com>
(cherry picked from commit c84211b)

Co-authored-by: Lenny Chen <55669665+lennessyy@users.noreply.github.com>
vault-token-factory-spectrocloud bot added a commit that referenced this pull request Jul 12, 2024
* docs: add additional qualifier

* docs: grammar

---------

Co-authored-by: Lenny Chen <lenny.chen@spectrocloud.com>
(cherry picked from commit c84211b)

Co-authored-by: Lenny Chen <55669665+lennessyy@users.noreply.github.com>
vault-token-factory-spectrocloud bot added a commit that referenced this pull request Jul 12, 2024
* docs: add additional qualifier

* docs: grammar

---------

Co-authored-by: Lenny Chen <lenny.chen@spectrocloud.com>
(cherry picked from commit c84211b)

Co-authored-by: Lenny Chen <55669665+lennessyy@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
auto-backport Enable backport backport-version-4-2 Backport change to version 4.2 backport-version-4-3 Backport change to version 4.3 backport-version-4-4 Backport change to version 4.4
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants