Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: Update README for admonitions #3387

Merged
merged 2 commits into from
Jul 16, 2024
Merged

chore: Update README for admonitions #3387

merged 2 commits into from
Jul 16, 2024

Conversation

yuliiiah
Copy link
Contributor

Describe the Change

This PR updates the docs repo README with details on admonitions.

Backports

Can this PR be backported?

  • Yes. Remember to add the relevant backport labels to your PR.
  • No. Please leave a short comment below about why this PR cannot be backported.

@yuliiiah yuliiiah added backport-version-4-0 Backport change to version 4.0 auto-backport Enable backport backport-version-3-4 Backport change to version 3.4 backport-version-4-1 Backport change to version 4.1 backport-version-4-2 Backport change to version 4.2 backport-version-4-3 Backport change to version 4.3 backport-version-4-4 Backport change to version 4.4 labels Jul 16, 2024
@yuliiiah yuliiiah requested a review from a team as a code owner July 16, 2024 15:45
@netlify Netlify
Copy link

netlify bot commented Jul 16, 2024 •
edited
Loading

✅ Deploy Preview for docs-spectrocloud ready!

Name Link
🔨 Latest commit b860427
🔍 Latest deploy log https://app.netlify.com/sites/docs-spectrocloud/deploys/6696965c6aecc1000837d263
😎 Deploy Preview https://deploy-preview-3387--docs-spectrocloud.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

karl-cardenas-coding
karl-cardenas-coding approved these changes Jul 16, 2024
View reviewed changes
Copy link
Contributor

@karl-cardenas-coding karl-cardenas-coding left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

@yuliiiah yuliiiah merged commit f87c018 into master Jul 16, 2024
15 checks passed
@yuliiiah yuliiiah deleted the fg-admonition-readme branch July 16, 2024 16:08
vault-token-factory-spectrocloud bot pushed a commit that referenced this pull request Jul 16, 2024
@yuliiiah
chore: Update README for admonitions (#3387)
1495cee 
* chore: Update README for admonitions

* chore: Fix wording and heading

(cherry picked from commit f87c018)
@vault-token-factory-spectrocloud vault-token-factory-spectrocloud bot mentioned this pull request Jul 16, 2024
Merged
vault-token-factory-spectrocloud bot pushed a commit that referenced this pull request Jul 16, 2024
@yuliiiah
chore: Update README for admonitions (#3387)
d941289 
* chore: Update README for admonitions

* chore: Fix wording and heading

(cherry picked from commit f87c018)
@vault-token-factory-spectrocloud vault-token-factory-spectrocloud bot mentioned this pull request Jul 16, 2024
Merged
vault-token-factory-spectrocloud bot pushed a commit that referenced this pull request Jul 16, 2024
@yuliiiah
chore: Update README for admonitions (#3387)
6ca5ca0 
* chore: Update README for admonitions

* chore: Fix wording and heading

(cherry picked from commit f87c018)
@vault-token-factory-spectrocloud vault-token-factory-spectrocloud bot mentioned this pull request Jul 16, 2024
Merged
vault-token-factory-spectrocloud bot pushed a commit that referenced this pull request Jul 16, 2024
@yuliiiah
chore: Update README for admonitions (#3387)
d3f3a9a 
* chore: Update README for admonitions

* chore: Fix wording and heading

(cherry picked from commit f87c018)
@vault-token-factory-spectrocloud vault-token-factory-spectrocloud bot mentioned this pull request Jul 16, 2024
Merged
vault-token-factory-spectrocloud bot pushed a commit that referenced this pull request Jul 16, 2024
@yuliiiah
chore: Update README for admonitions (#3387)
c4eca23 
* chore: Update README for admonitions

* chore: Fix wording and heading

(cherry picked from commit f87c018)
@vault-token-factory-spectrocloud vault-token-factory-spectrocloud bot mentioned this pull request Jul 16, 2024
Merged
vault-token-factory-spectrocloud bot pushed a commit that referenced this pull request Jul 16, 2024
@yuliiiah
chore: Update README for admonitions (#3387)
15bcb33 
* chore: Update README for admonitions

* chore: Fix wording and heading

(cherry picked from commit f87c018)
@vault-token-factory-spectrocloud vault-token-factory-spectrocloud bot mentioned this pull request Jul 16, 2024
Merged
@vault-token-factory-spectrocloud
Copy link
Contributor

💚 All backports created successfully

Status Branch Result
✅ version-4-0
✅ version-3-4
✅ version-4-1
✅ version-4-2
✅ version-4-3
✅ version-4-4

Note: Successful backport PRs will be merged automatically after passing CI.

Questions ?

Please refer to the Backport tool documentation and see the Github Action logs for details

vault-token-factory-spectrocloud bot added a commit that referenced this pull request Jul 16, 2024
@vault-token-factory-spectrocloud @yuliiiah
chore: Update README for admonitions (#3387) (#3389)
28c553b 
* chore: Update README for admonitions

* chore: Fix wording and heading

(cherry picked from commit f87c018)

Co-authored-by: Yuliia Horbenko <31223054+yuliiiah@users.noreply.github.com>
vault-token-factory-spectrocloud bot added a commit that referenced this pull request Jul 16, 2024
@vault-token-factory-spectrocloud @yuliiiah
chore: Update README for admonitions (#3387) (#3388)
fe5533b 
* chore: Update README for admonitions

* chore: Fix wording and heading

(cherry picked from commit f87c018)

Co-authored-by: Yuliia Horbenko <31223054+yuliiiah@users.noreply.github.com>
vault-token-factory-spectrocloud bot added a commit that referenced this pull request Jul 16, 2024
@vault-token-factory-spectrocloud @yuliiiah
chore: Update README for admonitions (#3387) (#3390)
81256a8 
* chore: Update README for admonitions

* chore: Fix wording and heading

(cherry picked from commit f87c018)

Co-authored-by: Yuliia Horbenko <31223054+yuliiiah@users.noreply.github.com>
vault-token-factory-spectrocloud bot added a commit that referenced this pull request Jul 16, 2024
@vault-token-factory-spectrocloud @yuliiiah
chore: Update README for admonitions (#3387) (#3391)
5773652 
* chore: Update README for admonitions

* chore: Fix wording and heading

(cherry picked from commit f87c018)

Co-authored-by: Yuliia Horbenko <31223054+yuliiiah@users.noreply.github.com>
vault-token-factory-spectrocloud bot added a commit that referenced this pull request Jul 16, 2024
@vault-token-factory-spectrocloud @yuliiiah
chore: Update README for admonitions (#3387) (#3392)
e0350f2 
* chore: Update README for admonitions

* chore: Fix wording and heading

(cherry picked from commit f87c018)

Co-authored-by: Yuliia Horbenko <31223054+yuliiiah@users.noreply.github.com>
vault-token-factory-spectrocloud bot added a commit that referenced this pull request Jul 16, 2024
@vault-token-factory-spectrocloud @yuliiiah
chore: Update README for admonitions (#3387) (#3393)
d840167 
* chore: Update README for admonitions

* chore: Fix wording and heading

(cherry picked from commit f87c018)

Co-authored-by: Yuliia Horbenko <31223054+yuliiiah@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@karl-cardenas-coding karl-cardenas-coding karl-cardenas-coding approved these changes

@addetz addetz Awaiting requested review from addetz addetz is a code owner automatically assigned from spectrocloud/docs-education

@lennessyy lennessyy Awaiting requested review from lennessyy lennessyy is a code owner automatically assigned from spectrocloud/docs-education

Assignees
No one assigned
Labels
auto-backport Enable backport backport-version-3-4 Backport change to version 3.4 backport-version-4-0 Backport change to version 4.0 backport-version-4-1 Backport change to version 4.1 backport-version-4-2 Backport change to version 4.2 backport-version-4-3 Backport change to version 4.3 backport-version-4-4 Backport change to version 4.4
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@yuliiiah @karl-cardenas-coding