Propagate closing channel before resolve timeout #223
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
phillebaba
force-pushed
the
p2p-resolve-timeout
branch
from
660493b
to
e99feae
Compare
phillebaba
force-pushed
the
p2p-resolve-timeout
branch
from
e99feae
to
193c730
Compare
phillebaba
commented
Oct 18, 2023
phillebaba
force-pushed
the
p2p-resolve-timeout
branch
from
193c730
to
785aa52
Compare
t1mt
pushed a commit
to t1mt/spegel
that referenced
this pull request
Sep 3, 2024
Propagate closing channel before resolve timeout
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change aims to address timeouts that occur when a key cannot be resolved at all. Currently every request that can't be resolved will be forced to wait the full timeout. A better solution is to exit early if libp2p closes the channel.