linkcheck builder: don't retry with HTTP GET after SSLError on HTTP HEAD #11431
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Feature or Bugfix
Purpose
SSLError
occurs following an HTTP HEAD operation, it seems unlikely that a subsequent HTTP GET will succeed, so don't attempt one.Detail
SSLError
exception that can be raised byrequests
is a subclass ofConnectionError
, so our logic to handle HTTP HEAD request failures has allowed an HTTP GET to occur as a fallback.Relates