-
Notifications
You must be signed in to change notification settings - Fork 469
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add integration test for Batchx509SVID RPC #5402
base: main
Are you sure you want to change the base?
Add integration test for Batchx509SVID RPC #5402
Conversation
ebe3772
to
1d27256
Compare
56cd285
to
ce239f3
Compare
else | ||
echo "Entry with SPIFFE ID ${SPIFFE_ID} exists." | ||
fi | ||
done |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this step as-is verifies that the entries exist, as created in the prior step.
however, neither this suite nor this step test the BatchNewX509SVID API
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
As I talked with @zmt the batch API is called internally when we add a single entry or create a batch operation as the test is already doing. The check for the existence of the entry fullfils the purpose of the task case if they were created in a batch operation and actually exist the operation is working as expected, right?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
what I believe you're detailing is Batch Entry Create, not Batch X509 SVID.
if the former, then the test needs to be re-named and the README updated
if the intention is to cover the latter, then comment still stands- this test as-is is not covering either explicit usage of that API or implicit usage by the running agent (which https://github.com/spiffe/spire/blob/main/test/integration/suites/fetch-x509-svids/05-fetch-x509-svids may already be doing)
Co-authored-by: amoore877 <11066940+amoore877@users.noreply.github.com> Signed-off-by: Thiago Valverde de Souza <valverde.thiago@gmail.com>
Pull Request check list
Provides a way to verify the operation of Batchx509SVID RPC.
Description of change
This PR introduces an automated integration test for the Batchx509SVID RPC in Open Source SPIRE. The new test script ensures the continuous operation of this RPC by verifying its functionality in a controlled environment. This enhancement addresses the previously identified gap in automated testing, thereby improving the reliability and stability of the SPIRE project by ensuring that the Batchx509SVID RPC performs as expected over time.
Which issue this PR fixes
Fixes 5401