don't fail FetchBundle if bundle does not exist #598
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The datastore was recently refactored to use Request/Response messages uniformly. Before that refactor, FetchBundle returned a Bundle message directly from the RPC and therefore had to fail if the bundle didn't exist (since it couldn't return a nil response). This commit changes the behavior of FetchBundle to match that of the other Fetch methods. Namely, if the requested bundle is not found, the call succeeds and returns an empty response object (i.e., the bundle pointer will be nil). All FetchBundle callers have been audited to make sure they handle an nil bundle appropriately. Signed-off-by: Andrew Harding <azdagron@gmail.com>
azdagron
requested review from
amartinezfayo,
evan2645,
MarcosDY,
martincapello and
walmav
as code owners
Signed-off-by: Andrew Harding <azdagron@gmail.com>
evan2645
approved these changes
Oct 17, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The datastore was recently refactored to use Request/Response messages
uniformly. Before that refactor, FetchBundle returned a Bundle message
directly from the RPC and therefore had to fail if the bundle didn't
exist (since it couldn't return a nil response).
This commit changes the behavior of FetchBundle to match that of the
other Fetch methods. Namely, if the requested bundle is not found, the
call succeeds and returns an empty response object (i.e., the bundle
pointer will be nil).
All FetchBundle callers have been audited to make sure they handle an
nil bundle appropriately.