Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

usr/raghu/additional_label_annotation: add support for additional lab… #36

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

raghavendraDBA
Copy link

@raghavendraDBA raghavendraDBA commented Oct 3, 2022

…els and annotation

fixes #35
helm template for deployment where my change is reflecting

apiVersion: apps/v1
kind: Deployment
metadata:
  name: spotinst-kubernetes-cluster-controller
  namespace: kube-system
  labels:
    helm.sh/chart: spotinst-kubernetes-cluster-controller-1.0.105
    app.kubernetes.io/version: "1.0.85"
    app.kubernetes.io/managed-by: Helm
    app.kubernetes.io/instance: release-name
    app.kubernetes.io/name: ocean-controller
    k8s-app: spotinst-kubernetes-cluster-controller
spec:
  replicas: 1
  revisionHistoryLimit: 10
  selector:
    matchLabels:
      k8s-app: spotinst-kubernetes-cluster-controller
  template:
    metadata:
      labels:
        k8s-app: spotinst-kubernetes-cluster-controller
        nologging: "true"
      annotations:
        co.elastic.logs/enabled: "false"

@JoshuaJackson-jobvite
Copy link

You've updated the code but not the documentation in the Readme.md for the chart itself to document the new additions. Please ensure that you update and modify the readme so that it accurately reflects the changes you've made.

@raghavendraDBA
Copy link
Author

You've updated the code but not the documentation in the Readme.md for the chart itself to document the new additions. Please ensure that you update and modify the readme so that it accurately reflects the changes you've made.

updated readme

@stevenfeltner
Copy link

@yinnonbar @verchol Are we able to review this?

@rfaurevincent-wiser
Copy link

Hi @stevenfeltner @yinnonbar @verchol @rkrmr33 @TalShafir, this would allow us to use the Vault injector agent as well as anything that requires spec: template: annotations so we're interested in seeing it merged.
I was about to open a similar PR myself, I can help if this one is missing anything.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants