Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Colour issues when choosing Light theme for code snippets #14

Closed
bclozel opened this issue May 13, 2019 · 1 comment · Fixed by #24
Closed

Colour issues when choosing Light theme for code snippets #14

bclozel opened this issue May 13, 2019 · 1 comment · Fixed by #24
Assignees
@oodamien
Milestone
0.1.3.RELEASE

Comments

@bclozel
Copy link
Member

bclozel commented May 13, 2019

As suggested by several community members (for example, here), I'd like to move to a light theme for code snippets by default. I personally like the dark ones very much, but it's apparently not friendly to people with colour vision issues.

I've tried using the github theme (provided by spring-doc-resources) and I'm seeing the following.

Screenshot 2019-05-13 at 17 17 01

Is there something we can do to make things work with both light and dark themes? If not, I think we should default on a light one.
@bclozel bclozel added this to the 0.1.3.RELEASE milestone May 13, 2019
oodamien added a commit to oodamien/spring-doc-resources that referenced this issue Aug 20, 2019
@oodamien
Code highlight: change to light theme
704a049 
Closed spring-io#14
@oodamien oodamien mentioned this issue Aug 20, 2019
Merged
bclozel pushed a commit that referenced this issue Aug 30, 2019
@oodamien @bclozel
Code highlight: change to light theme
792437b 
Closed #14
@bclozel bclozel mentioned this issue Sep 23, 2019
Closed
@odrotbohm
Copy link

This changes breaks the code highlighting for projects that use the atom-one-dark-reasonable highlight.js theme as suggested in the readme.

bclozel added a commit that referenced this issue Feb 26, 2020
@bclozel
Mark github theme as the default in documentation
7a4d5c3 
As seen on gh-14, the global theme is now adapted to light-variants of
code hilighting themes. This should be reflected on the project
documentation.
@bclozel bclozel mentioned this issue Apr 2, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@oodamien oodamien

Labels
None yet
Projects
None yet
Milestone
0.1.3.RELEASE
Development

Successfully merging a pull request may close this issue.

Code highlight: change to light theme oodamien/spring-doc-resources
3 participants
@bclozel @odrotbohm @oodamien