Provide error pages

[snicoll]

Now that we've re-enabled the whitelabel page, we should provide a static error page that's a bit more inline with the current UI.

[10xtechie]

@snicoll ,
Do you mean that we should have a static error page e.g error.html and fill it with appropriate HTTP error code such as 404, 500 etc - with a generic error massage? Also, do you want any further details about the error; for example: which java exception causes the 500 error, so on and so forth?

[snicoll]

@10xtechie thanks for the interest. I am not sure how we're going to approach this to be honest. Our web UI is doing things that may impact what we decide to do. Essentially, this is about providing a proper error page when something goes wrong (with the same UI styling). But it is also about making sure that if you hit the service directly, you get back the usual error attributes.

[10xtechie]

@snicoll
Thanks so very much for your reply!!
Let me think aloud here: on the sever side, I would create a generic error handling controller which will produce usual error attributes both in HTML and JSON and on the client side, a generic error page template, which is consistent with our web UI and will consume data produced by that generic error controller. Please let me know what you think :)

[snicoll]

I would create a generic error handling controller

That is supposed to be taken care by Spring Boot's default error handling. Unfortunately this proves to be a bit tricky with our web client for some reason. I am happy for you giving a try. We can discuss based on a PR.

[10xtechie]

@snicoll ,
Thanks for insights! I will try and create a PR. Please assign it to me :)

[10xtechie]

@snicoll ,
Thanks for assigning this issue to me! I have created a PR for the same. Please have a look.