Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Introducing record class to only customer-service to start with #253

Merged
merged 14 commits into from
Jan 5, 2024

Conversation

shobhakamath
Copy link
Contributor

I am creating a smaller PR and have Included record to only the customer-service Microservices.
Will apply to other micro services if this looks good.

@shobhakamath shobhakamath marked this pull request as ready for review January 3, 2024 08:43
Copy link
Member

@arey arey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your work.
I've made a few comments.

@shobhakamath
Copy link
Contributor Author

Thank you for the comments.
I have included my comments. Can you please advise if I have missed anything.

Copy link

sonarcloud bot commented Jan 5, 2024

Quality Gate Passed Quality Gate passed

Kudos, no new issues were introduced!

0 New issues
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarCloud

@arey
Copy link
Member

arey commented Jan 5, 2024

Everything looks good to me
Thanks @shobhakamath

@arey arey merged commit 39f6670 into spring-petclinic:main Jan 5, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants