Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add precondition check when scanning #15

Closed
fabapp2 opened this issue Mar 2, 2022 · 0 comments · Fixed by #37
Closed

Add precondition check when scanning #15

fabapp2 opened this issue Mar 2, 2022 · 0 comments · Fixed by #37

Comments

@fabapp2
Copy link
Collaborator

fabapp2 commented Mar 2, 2022

What needs to be done

A set of preconditions should be run at the beginning of a scan to warn the user about
potential problems when scanning an application that does not fulfill requirements.

Why it needs to be done

For a better UX a user should be warned about expected problems when scanning (but before applying recipes) an application that does not fulfill given preconditions.

Acceptance Criteria

Given A user scans an application that does not fulfill one or more preconditions +
When SBM performs a precondition check that fails +
Then A warning is shown to the user and the scan is cancelled.

Precondition Warning
No pom.xml found SBM requires a Maven build file. Please provide a minimal pom.xml.
no dir src/main/java exists Precondition check could not find a src/main/java dir. This dir is required.
Git-Support is enabled but no .git exists Git-Support is enabled but the scanned project is not under git.
Multiple modules found Maven reactor support is experimental and not fully supported.

Additional Information

@fabapp2 fabapp2 linked a pull request Mar 22, 2022 that will close this issue
ravig-kant referenced this issue in ravig-kant/spring-boot-migrator Jul 3, 2022
This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant