Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

MIgrate all properties to @Stateless when migrating ejb-jar.xml to annotation #56

Closed
fabapp2 opened this issue Mar 28, 2022 · 2 comments
Closed

MIgrate all properties to @Stateless when migrating ejb-jar.xml to annotation #56

fabapp2 opened this issue Mar 28, 2022 · 2 comments
Labels
good first issue Good for newcomers JEE/EJB/deployment-descriptor

Comments

@fabapp2
Copy link
Collaborator

fabapp2 commented Mar 28, 2022 •
edited
Loading

What needs to be done

All possible attributes for stateless session bean declarations given in an EJB deployment descriptor (ejb-jar.xml) must be migrated to annotations when migrate-ejb-jar-deployment-descriptor is applied.

Why it needs to be done

Currently, only beanName attribute is migrated.
If an ejb-jar.xml contains additional attributes these are not migrated and the migration is broken/incomplete.

Additional Information

See MigrateEjbDeploymentDescriptor.handleStatelessSessionBean()
@ravig-kant
Copy link
Contributor

Hi @fabapp2

I will take a stab at it.

ravig-kant pushed a commit to ravig-kant/spring-boot-migrator that referenced this issue May 20, 2022
@ravigkant
spring-projects-experimental#56 Migrate all properties to @stateless …
b3ba598 
…when migrating ejb-jar.xml to annotation
@ravig-kant
Copy link
Contributor

PR - #123

ravig-kant pushed a commit to ravig-kant/spring-boot-migrator that referenced this issue May 22, 2022
@ravigkant
spring-projects-experimental#56 Fixed failing test and added new tests
4e5c331
This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
good first issue Good for newcomers JEE/EJB/deployment-descriptor
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@ravig-kant @fabapp2