Skip to content

Commit

Permalink
Consistent Lock field declaration (instead of ReentrantLock field type)
Browse files Browse the repository at this point in the history
(cherry picked from commit b415361)
  • Loading branch information
jhoeller committed Feb 13, 2024
1 parent b11ff96 commit b976ee3
Show file tree
Hide file tree
Showing 3 changed files with 10 additions and 9 deletions.
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
/*
* Copyright 2002-2022 the original author or authors.
* Copyright 2002-2024 the original author or authors.
*
* Licensed under the Apache License, Version 2.0 (the "License");
* you may not use this file except in compliance with the License.
Expand Down Expand Up @@ -27,6 +27,7 @@
import java.util.Properties;
import java.util.concurrent.ConcurrentHashMap;
import java.util.concurrent.ConcurrentMap;
import java.util.concurrent.locks.Lock;
import java.util.concurrent.locks.ReentrantLock;

import org.springframework.context.ResourceLoaderAware;
Expand Down Expand Up @@ -400,7 +401,7 @@ protected PropertiesHolder getProperties(String filename) {

/**
* Refresh the PropertiesHolder for the given bundle filename.
* The holder can be {@code null} if not cached before, or a timed-out cache entry
* <p>The holder can be {@code null} if not cached before, or a timed-out cache entry
* (potentially getting re-validated against the current last-modified timestamp).
* @param filename the bundle filename (basename + Locale)
* @param propHolder the current PropertiesHolder for the bundle
Expand Down Expand Up @@ -561,7 +562,7 @@ protected class PropertiesHolder {

private volatile long refreshTimestamp = -2;

private final ReentrantLock refreshLock = new ReentrantLock();
private final Lock refreshLock = new ReentrantLock();

/** Cache to hold already generated MessageFormats per message code. */
private final ConcurrentMap<String, Map<Locale, MessageFormat>> cachedMessageFormats =
Expand Down
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
/*
* Copyright 2002-2023 the original author or authors.
* Copyright 2002-2024 the original author or authors.
*
* Licensed under the Apache License, Version 2.0 (the "License");
* you may not use this file except in compliance with the License.
Expand All @@ -26,6 +26,7 @@
import java.util.Map;
import java.util.concurrent.ConcurrentHashMap;
import java.util.concurrent.atomic.AtomicReference;
import java.util.concurrent.locks.Lock;
import java.util.concurrent.locks.ReentrantLock;

import reactor.core.publisher.Mono;
Expand Down Expand Up @@ -315,12 +316,10 @@ private class ExpiredSessionChecker {
/** Max time between expiration checks. */
private static final int CHECK_PERIOD = 60 * 1000;


private final ReentrantLock lock = new ReentrantLock();
private final Lock lock = new ReentrantLock();

private Instant checkTime = clock.instant().plus(CHECK_PERIOD, ChronoUnit.MILLIS);


public void checkIfNecessary(Instant now) {
if (this.checkTime.isBefore(now)) {
removeExpiredSessions(now);
Expand Down
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
/*
* Copyright 2002-2023 the original author or authors.
* Copyright 2002-2024 the original author or authors.
*
* Licensed under the Apache License, Version 2.0 (the "License");
* you may not use this file except in compliance with the License.
Expand All @@ -25,6 +25,7 @@
import java.util.TreeMap;
import java.util.concurrent.ConcurrentHashMap;
import java.util.concurrent.atomic.AtomicInteger;
import java.util.concurrent.locks.Lock;
import java.util.concurrent.locks.ReentrantLock;

import org.apache.commons.logging.Log;
Expand Down Expand Up @@ -98,7 +99,7 @@ public class SubProtocolWebSocketHandler

private volatile long lastSessionCheckTime = System.currentTimeMillis();

private final ReentrantLock sessionCheckLock = new ReentrantLock();
private final Lock sessionCheckLock = new ReentrantLock();

private final DefaultStats stats = new DefaultStats();

Expand Down

0 comments on commit b976ee3

Please sign in to comment.