Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Create a WebFilter for ServerWebExchange Reactor Context [SPR-17213] #21746

Closed
spring-projects-issues opened this issue Aug 24, 2018 · 3 comments
Closed

Create a WebFilter for ServerWebExchange Reactor Context [SPR-17213] #21746

spring-projects-issues opened this issue Aug 24, 2018 · 3 comments
Assignees
@rstoyanchev
Labels
in: web Issues in web modules (web, webmvc, webflux, websocket) type: enhancement A general enhancement
Milestone
5.2 M2

Comments

@spring-projects-issues
Copy link
Collaborator

spring-projects-issues commented Aug 24, 2018 •
edited
Loading

Rob Winch opened SPR-17213 and commented

Similar to RequestContextFilter, it would be nice if there was a WebFilter that populated the ServerWebExchange in the Reactor Context. This would be benefit to Spring Security's OAuth support. It would also likely provide value for logging, metrics, etc.

Affects: 5.1 RC2

Issue Links:

0 votes, 5 watchers
@spring-projects-issues
Copy link
Collaborator Author

spring-projects-issues commented Oct 12, 2018 •
edited
Loading

Rossen Stoyanchev commented

The opposite seems to also be of potential interest based on #21477.

@spring-projects-issues spring-projects-issues added type: enhancement A general enhancement in: web Issues in web modules (web, webmvc, webflux, websocket) labels Jan 11, 2019
@spring-projects-issues spring-projects-issues added this to the 5.2 RC1 milestone Jan 11, 2019
This was referenced Jan 11, 2019
Closed
Closed
@gregturn
Copy link
Contributor

This would also benefit Spring HATEOAS and reactive link creation.

@rstoyanchev rstoyanchev removed their assignment Jan 28, 2019
@mkopylec
Copy link

I also need this feature.

@jhoeller jhoeller modified the milestones: 5.2 M1, 5.2 M2 Mar 23, 2019
@rstoyanchev rstoyanchev self-assigned this Apr 15, 2019
@gregturn gregturn mentioned this issue Apr 16, 2019
Merged
gregturn added a commit to spring-projects/spring-hateoas that referenced this issue Apr 16, 2019
@gregturn
#983 - Switch to Spring's ServerWebExchangeContextFilter.
0a22b38 
Replace HypermediaWebFilter with ServerWebExchangeContextFilter.

Related issues: spring-projects/spring-framework#21746
odrotbohm pushed a commit to spring-projects/spring-hateoas that referenced this issue Jun 27, 2019
@gregturn @odrotbohm
#983 - Switch to Spring's ServerWebExchangeContextFilter.
6a7e343 
Replace HypermediaWebFilter with ServerWebExchangeContextFilter.

Related issues: #986, spring-projects/spring-framework#21746.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@rstoyanchev rstoyanchev

Labels
in: web Issues in web modules (web, webmvc, webflux, websocket) type: enhancement A general enhancement
Projects
None yet
Milestone
5.2 M2
Development

No branches or pull requests
5 participants
@gregturn @rstoyanchev @jhoeller @mkopylec @spring-projects-issues